cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Add a 'throwIfNamespace' option for JSX transform (#6563)

Browse Source 
* Added tests for ifThrowNamespace flag

* JSX transformator could work with XMLNamespaces (ifThrowNamespace flag)

* Use template literal instead

* Attempt to reword the message

* Added docs

* Reworded docs

* Reworded docs

* Fixed missing space in error message
This commit is contained in:
Jakub Beneš
2017-10-29 02:44:15 +02:00
committed by Henry Zhu
parent 9ac326b075
commit 04d2c030be
10 changed files with 58 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
packages/babel-plugin-transform-react-jsx/README.md
View File

@@ -78,7 +78,8 @@ With options:
{
"plugins": [
["@babel/transform-react-jsx", {
"pragma": "dom" // default pragma is React.createElement
"pragma": "dom", // default pragma is React.createElement
"throwIfNamespace": false // defaults to true
}]
]
}
@@ -113,3 +114,13 @@ Note that the `@jsx React.DOM` pragma has been deprecated as of React v0.12
`boolean`, defaults to `false`.
When spreading props, use `Object.assign` directly instead of Babel's extend helper.
### `throwIfNamespace`
`boolean`, defaults to `true`.
Toggles whether or not to throw an error if a XML namespaced tag name is used. For example:
<f:image />
Though the JSX spec allows this, it is disabled by default since React's JSX does not currently have support for it.

4
packages/babel-plugin-transform-react-jsx/src/index.js
View File

@@ -3,6 +3,8 @@ import helper from "@babel/helper-builder-react-jsx";
export default function({ types: t }, options) {
const pragma = options.pragma || "React.createElement";
const throwIfNamespace =
options.throwIfNamespace === undefined ? true : !!options.throwIfNamespace;
const JSX_ANNOTATION_REGEX = /\*?\s*@jsx\s+([^\s]+)/;
@@ -20,6 +22,8 @@ export default function({ types: t }, options) {
post(state, pass) {
state.callee = pass.get("jsxIdentifier")();
},
throwIfNamespace,
});
visitor.Program = function(path, state) {

2
packages/babel-plugin-transform-react-jsx/test/fixtures/react/should-disallow-xml-namespacing/options.json vendored
View File

@@ -1,3 +1,3 @@
{
"throws": "Namespace tags are not supported. ReactJSX is not XML."
"throws": "Namespace tags are not supported by default. React's JSX doesn't support namespace tags. You can turn on the 'throwIfNamespace' flag to bypass this warning."
}

1
packages/babel-plugin-transform-react-jsx/test/fixtures/react/should-support-xml-namespaces-if-flag/actual.js vendored Normal file
View File

@@ -0,0 +1 @@
<f:image />;

1
packages/babel-plugin-transform-react-jsx/test/fixtures/react/should-support-xml-namespaces-if-flag/expected.js vendored Normal file
View File

@@ -0,0 +1 @@
h("f:image", null);

11
packages/babel-plugin-transform-react-jsx/test/fixtures/react/should-support-xml-namespaces-if-flag/options.json vendored Normal file
View File

@@ -0,0 +1,11 @@
{
"plugins": [
[
"transform-react-jsx",
{
"pragma": "h",
"throwIfNamespace": false
}
]
]
}

1
packages/babel-plugin-transform-react-jsx/test/fixtures/react/should-throw-error-namespaces-if-not-flag/actual.js vendored Normal file
View File

@@ -0,0 +1 @@
<f:image />;

12
packages/babel-plugin-transform-react-jsx/test/fixtures/react/should-throw-error-namespaces-if-not-flag/options.json vendored Normal file
View File

@@ -0,0 +1,12 @@
{
"plugins": [
[
"transform-react-jsx",
{
"pragma": "h",
"throwIfNamespace": true
}
]
],
"throws": "Namespace tags are not supported by default. React's JSX doesn't support namespace tags. You can turn on the 'throwIfNamespace' flag to bypass this warning."
}