cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Also check AssignmentPatterns for export name (#9521)

Browse Source
This commit is contained in:
Daniel Tschinder 2019-02-15 22:55:03 -08:00 committed by GitHub
parent d1fe2d05f4
commit 058f057426
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
packages/babel-parser/src/parser/statement.js
View File

@ -1816,7 +1816,9 @@ export default class StatementParser extends ExpressionParser {
} }
checkDeclaration(node: N.Pattern | N.ObjectProperty): void { checkDeclaration(node: N.Pattern | N.ObjectProperty): void {
if (node.type === "ObjectPattern") { if (node.type === "Identifier") {
this.checkDuplicateExports(node, node.name);
} else if (node.type === "ObjectPattern") {
for (const prop of node.properties) { for (const prop of node.properties) {
this.checkDeclaration(prop); this.checkDeclaration(prop);
} }
@ -1830,8 +1832,8 @@ export default class StatementParser extends ExpressionParser {
this.checkDeclaration(node.value); this.checkDeclaration(node.value);
} else if (node.type === "RestElement") { } else if (node.type === "RestElement") {
this.checkDeclaration(node.argument); this.checkDeclaration(node.argument);
} else if (node.type === "Identifier") { } else if (node.type === "AssignmentPattern") {
this.checkDuplicateExports(node, node.name); this.checkDeclaration(node.left);
} }
} }

2
packages/babel-parser/test/fixtures/es2015/modules/duplicate-named-export-destructuring-assignment/input.js vendored Normal file
View File

@ -0,0 +1,2 @@
export { foo };
export const { foo = 1 } = bar;

4
packages/babel-parser/test/fixtures/es2015/modules/duplicate-named-export-destructuring-assignment/options.json vendored Normal file
View File

@ -0,0 +1,4 @@
{
"sourceType": "module",
"throws": "`foo` has already been exported. Exported identifiers must be unique. (2:15)"
}