Clean up @babel/eslint-plugin-development (#10757)

* Clean up @babel/eslint-plugin-development

* Add directory field to package.json

eslint/babel-eslint-plugin-development/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@babel/eslint-plugin-development",
-  "version": "1.0.1",
-  "description": "A set of eslint rules to enforce best practices in the development of Babel plugins.",
+  "version": "0.0.0",
+  "description": "ESLint rules that enforce best practices in the development of Babel plugins.",
   "private": true,
   "keywords": [
     "eslint",
@@ -26,6 +26,11 @@
   "license": "MIT",
   "repository": {
     "type": "git",
-    "url": "https://github.com/babel/eslint-plugin-babel-plugin.git"
-  }
+    "url": "https://github.com/babel/babel.git",
+    "directory": "eslint/babel-eslint-plugin-development"
+  },
+  "bugs": {
+    "url": "https://github.com/babel/babel/issues"
+  },
+  "homepage": "https://github.com/babel/babel/tree/master/eslint/babel-eslint-plugin-development"
 }

eslint/babel-eslint-plugin-development/src/index.js

@@ -1,9 +1,11 @@
-"use strict";
+import noDeprecatedClone from "./rules/no-deprecated-clone";
+import noUndefinedIdentifier from "./rules/no-undefined-identifier";
+import pluginName from "./rules/plugin-name";
 
-module.exports = {
+export default {
   rules: {
-    "no-deprecated-clone": require("./rules/no-deprecated-clone"),
-    "no-undefined-identifier": require("./rules/no-undefined-identifier"),
-    "plugin-name": require("./rules/plugin-name"),
+    "no-deprecated-clone": noDeprecatedClone,
+    "no-undefined-identifier": noUndefinedIdentifier,
+    "plugin-name": pluginName,
   },
 };

eslint/babel-eslint-plugin-development/src/rules/no-deprecated-clone.js

@@ -1,9 +1,7 @@
-"use strict";
+import getReferenceOrigin from "../utils/get-reference-origin";
+import isFromBabelTypes from "../utils/is-from-babel-types";
 
-const getReferenceOrigin = require("../utils/get-reference-origin");
-const isFromBabelTypes = require("../utils/is-from-babel-types");
-
-module.exports = {
+export default {
   meta: {
     schema: [],
     fixable: "code",

eslint/babel-eslint-plugin-development/src/rules/no-undefined-identifier.js

@@ -1,7 +1,5 @@
-"use strict";
-
-const getReferenceOrigin = require("../utils/get-reference-origin");
-const isFromBabelTypes = require("../utils/is-from-babel-types");
+import getReferenceOrigin from "../utils/get-reference-origin";
+import isFromBabelTypes from "../utils/is-from-babel-types";
 
 function firstArgumentIsUndefinedString(argumentsArray) {
   return (
@@ -11,7 +9,7 @@ function firstArgumentIsUndefinedString(argumentsArray) {
   );
 }
 
-module.exports = {
+export default {
   meta: {
     schema: [],
   },

eslint/babel-eslint-plugin-development/src/rules/plugin-name.js

@@ -1,6 +1,4 @@
-"use strict";
-
-const isBabelPluginFactory = require("../utils/is-babel-plugin-factory");
+import isBabelPluginFactory from "../utils/is-babel-plugin-factory";
 
 function getReturnValue(node) {
   const { body } = node;
@@ -14,7 +12,7 @@ function getReturnValue(node) {
   return body;
 }
 
-module.exports = {
+export default {
   meta: {
     schema: [],
   },

eslint/babel-eslint-plugin-development/src/utils/get-export-name.js

@@ -1,6 +1,4 @@
-"use strict";
-
-module.exports = function getExportName(node) {
+export default function getExportName(node) {
   const { parent } = node;
 
   if (parent.type === "ExportDefaultDeclaration") {
@@ -21,4 +19,4 @@ module.exports = function getExportName(node) {
   ) {
     return "module.exports";
   }
-};
+}

eslint/babel-eslint-plugin-development/src/utils/get-reference-origin.js

@@ -1,7 +1,3 @@
-"use strict";
-
-module.exports = getReferenceOrigin;
-
 /*::
 type ReferenceOriginImport = { kind: "import", source: string, name: string };
 type ReferenceOriginParam = {
@@ -26,7 +22,10 @@ type ReferenceOrigin =
 // from.
 // It resolves imports, parameters of exported functions and property accesses.
 // See the ReferenceOrigin type for more informations.
-function getReferenceOrigin(node, scope) /*: ?ReferenceOrigin */ {
+export default function getReferenceOrigin(
+  node,
+  scope,
+) /*: ?ReferenceOrigin */ {
   if (node.type === "Identifier") {
     const variable = getVariableDefinition(node.name, scope);
     if (!variable) return null;

eslint/babel-eslint-plugin-development/src/utils/is-babel-plugin-factory.js

@@ -1,9 +1,7 @@
-"use strict";
+import getReferenceOrigin from "./get-reference-origin";
+import getExportName from "./get-export-name";
 
-const getReferenceOrigin = require("./get-reference-origin");
-const getExportName = require("./get-export-name");
-
-module.exports = function isBabelPluginFactory(node, scope) {
+export default function isBabelPluginFactory(node, scope) {
   const { parent } = node;
 
   if (parent.type === "CallExpression") {
@@ -23,4 +21,4 @@ module.exports = function isBabelPluginFactory(node, scope) {
   // export default function ({ types: t }) {}
   // module.exports = function ({ types: t }) {}
   return exportName === "default" || exportName === "module.exports";
-};
+}

eslint/babel-eslint-plugin-development/src/utils/is-from-babel-types.js

@@ -1,10 +1,8 @@
-"use strict";
-
-const isBabelPluginFactory = require("./is-babel-plugin-factory");
+import isBabelPluginFactory from "./is-babel-plugin-factory";
 
 // Check if a ReferenceOrigin (returned by ./get-reference-origin.js)
 // is a reference to a @babel/types export.
-module.exports = function isFromBabelTypes(
+export default function isFromBabelTypes(
   origin /*: ReferenceOrigin */,
   scope /*: Scope */,
 ) {
@@ -32,4 +30,4 @@ module.exports = function isFromBabelTypes(
   }
 
   return false;
-};
+}

eslint/babel-eslint-plugin-development/test/rules/no-deprecated-clone.js

@@ -1,7 +1,5 @@
-"use strict";
-
-const rule = require("../../src/rules/no-deprecated-clone");
-const { RuleTester } = require("eslint");
+import rule from "../../src/rules/no-deprecated-clone";
+import { RuleTester } from "eslint";
 
 const cloneError = "t.clone() is deprecated. Use t.cloneNode() instead.";
 const cloneDeepError =

eslint/babel-eslint-plugin-development/test/rules/no-undefined-identifier.js

@@ -1,7 +1,5 @@
-"use strict";
-
-const rule = require("../../src/rules/no-undefined-identifier");
-const { RuleTester } = require("eslint");
+import rule from "../../src/rules/no-undefined-identifier";
+import { RuleTester } from "eslint";
 
 const error =
   "Use path.scope.buildUndefinedNode() to create an undefined identifier directly.";

eslint/babel-eslint-plugin-development/test/rules/plugin-name.js

@@ -1,7 +1,5 @@
-"use strict";
-
-const rule = require("../../src/rules/plugin-name");
-const { RuleTester } = require("eslint");
+import rule from "../../src/rules/plugin-name";
+import { RuleTester } from "eslint";
 
 const missingPluginError = "This file does not export a Babel plugin.";
 const missingNameError = "This Babel plugin doesn't have a 'name' property.";