Avoid adding unnecessary closure for block scoping (#5246)
When you write
```
for (const x of l) {
setTimeout(() => x);
}
```
we need to add a closure because the variable is meant to be block-scoped and recreated each time the block runs. We do this.
However, we also add the closure when no loop is present. This isn't necessary, because if no loop is present then each piece of code runs at most once. I changed the transform to only add a closure if a variable is referenced from within a loop.
This commit is contained in:
@@ -1,17 +1,11 @@
|
||||
function render(flag) {
|
||||
if (flag) {
|
||||
var _ret = function () {
|
||||
var bar = "bar";
|
||||
var bar = "bar";
|
||||
|
||||
[].map(() => bar);
|
||||
[].map(() => bar);
|
||||
|
||||
return {
|
||||
v: <foo bar={bar} />
|
||||
};
|
||||
}();
|
||||
|
||||
if (typeof _ret === "object") return _ret.v;
|
||||
return <foo bar={bar} />;
|
||||
}
|
||||
|
||||
return null;
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user