cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

fix(types): correct typescript function headers (#10404)

Browse Source 
Flow maybe types state;

> Maybe types accept the provided type as well as null or undefined. So ?number would mean number, null, or undefined.

So in this case, explicitly allow the type, null, or undefined in the
typescript definition.

Fixes #10403
This commit is contained in:
Matt Forster 2019-09-06 12:54:03 -06:00 committed by Nicolò Ribaudo
parent fc8e14264c
commit 15b63bc89e
No known key found for this signature in database
GPG Key ID: 6F2E38DF3E4A6D0C
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/babel-types/scripts/generators/flow.js
View File

@ -146,7 +146,7 @@ lines.push(
`declare function isLet(node: BabelNode): boolean`, `declare function isLet(node: BabelNode): boolean`,
`declare function isNode(node: ?Object): boolean`, `declare function isNode(node: ?Object): boolean`,
`declare function isNodesEquivalent(a: any, b: any): boolean`, `declare function isNodesEquivalent(a: any, b: any): boolean`,
`declare function isPlaceholderType(placeholderType: ?string, targetType: string): boolean`, `declare function isPlaceholderType(placeholderType: string, targetType: string): boolean`,
`declare function isReferenced(node: BabelNode, parent: BabelNode, grandparent?: BabelNode): boolean`, `declare function isReferenced(node: BabelNode, parent: BabelNode, grandparent?: BabelNode): boolean`,
`declare function isScope(node: BabelNode, parent: BabelNode): boolean`, `declare function isScope(node: BabelNode, parent: BabelNode): boolean`,
`declare function isSpecifierDefault(specifier: BabelNodeModuleSpecifier): boolean`, `declare function isSpecifierDefault(specifier: BabelNodeModuleSpecifier): boolean`,

6
packages/babel-types/scripts/generators/typescript.js
View File

@ -153,13 +153,13 @@ lines.push(
`export function isBlockScoped(node: Node): boolean`, `export function isBlockScoped(node: Node): boolean`,
`export function isImmutable(node: Node): boolean`, `export function isImmutable(node: Node): boolean`,
`export function isLet(node: Node): boolean`, `export function isLet(node: Node): boolean`,
`export function isNode(node: ?object): boolean`, `export function isNode(node: object | null | undefined): boolean`,
`export function isNodesEquivalent(a: any, b: any): boolean`, `export function isNodesEquivalent(a: any, b: any): boolean`,
`export function isPlaceholderType(placeholderType: ?string, targetType: string): boolean`, `export function isPlaceholderType(placeholderType: string, targetType: string): boolean`,
`export function isReferenced(node: Node, parent: Node, grandparent?: Node): boolean`, `export function isReferenced(node: Node, parent: Node, grandparent?: Node): boolean`,
`export function isScope(node: Node, parent: Node): boolean`, `export function isScope(node: Node, parent: Node): boolean`,
`export function isSpecifierDefault(specifier: ModuleSpecifier): boolean`, `export function isSpecifierDefault(specifier: ModuleSpecifier): boolean`,
`export function isType(nodetype: ?string, targetType: string): boolean`, `export function isType(nodetype: string | null | undefined, targetType: string): boolean`,
`export function isValidES3Identifier(name: string): boolean`, `export function isValidES3Identifier(name: string): boolean`,
`export function isValidES3Identifier(name: string): boolean`, `export function isValidES3Identifier(name: string): boolean`,
`export function isValidIdentifier(name: string): boolean`, `export function isValidIdentifier(name: string): boolean`,

2
packages/babel-types/src/validators/isPlaceholderType.js
View File

@ -5,7 +5,7 @@ import { PLACEHOLDERS_ALIAS } from "../definitions";
* Test if a `placeholderType` is a `targetType` or if `targetType` is an alias of `placeholderType`. * Test if a `placeholderType` is a `targetType` or if `targetType` is an alias of `placeholderType`.
*/ */
export default function isPlaceholderType( export default function isPlaceholderType(
placeholderType: ?string, placeholderType: string,
targetType: string, targetType: string,
): boolean { ): boolean {
if (placeholderType === targetType) return true; if (placeholderType === targetType) return true;