Merge pull request #5008 from babel/fix-5004

Don't try to visit ArrowFunctionExpression, they cannot be named

packages/babel-plugin-transform-es2015-function-name/src/index.js

@@ -3,7 +3,7 @@ import nameFunction from "babel-helper-function-name";
 export default function () {
   return {
     visitor: {
-      "ArrowFunctionExpression|FunctionExpression": {
+      FunctionExpression: {
         exit(path) {
           if (path.key !== "value" && !path.parentPath.isObjectProperty()) {
             const replacement = nameFunction(path);

packages/babel-plugin-transform-es2015-function-name/test/fixtures/function-name/with-arrow-functions-transform-spec/actual.js

@@ -0,0 +1,5 @@
+// I don't know if this is a bug with arrow-functions spec: true
+// or with function-name, but the functions are missing their names.
+const x = () => x;
+const y = x => x();
+const z = { z: () => y(x) }.z;

packages/babel-plugin-transform-es2015-function-name/test/fixtures/function-name/with-arrow-functions-transform-spec/expected.js

@@ -0,0 +1,16 @@
+var _this = this;
+
+// I don't know if this is a bug with arrow-functions spec: true
+// or with function-name, but the functions are missing their names.
+const x = function () {
+  babelHelpers.newArrowCheck(this, _this);
+  return x;
+}.bind(this);
+const y = function (x) {
+  babelHelpers.newArrowCheck(this, _this);
+  return x();
+}.bind(this);
+const z = { z: function z() {
+    babelHelpers.newArrowCheck(this, _this);
+    return y(x);
+  }.bind(this) }.z;

packages/babel-plugin-transform-es2015-function-name/test/fixtures/function-name/with-arrow-functions-transform-spec/options.json

@@ -0,0 +1,3 @@
+{
+  "plugins": ["external-helpers", "transform-es2015-function-name", [ "transform-es2015-arrow-functions", { "spec": true } ]]
+}

packages/babel-plugin-transform-es2015-function-name/test/fixtures/function-name/with-arrow-functions-transform/actual.js

@@ -0,0 +1,3 @@
+const x = () => x;
+const y = x => x();
+const z = { z: () => y(x) }.z;

packages/babel-plugin-transform-es2015-function-name/test/fixtures/function-name/with-arrow-functions-transform/expected.js

@@ -0,0 +1,9 @@
+const x = function x() {
+  return x;
+};
+const y = function y(x) {
+  return x();
+};
+const z = { z: function z() {
+    return y(x);
+  } }.z;

packages/babel-plugin-transform-es2015-function-name/test/fixtures/function-name/with-arrow-functions-transform/options.json

@@ -0,0 +1,3 @@
+{
+  "plugins": ["external-helpers", "transform-es2015-function-name", "transform-es2015-arrow-functions"]
+}

packages/babel-plugin-transform-es2015-function-name/test/fixtures/issues/5004/actual.js

@@ -0,0 +1,2 @@
+export const x = ({x}) => x;
+export const y = function () {};

packages/babel-plugin-transform-es2015-function-name/test/fixtures/issues/5004/expected.js

@@ -0,0 +1,2 @@
+export const x = ({ x }) => x;
+export const y = function y() {};

packages/babel-plugin-transform-es2015-function-name/test/fixtures/issues/5004/options.json

@@ -0,0 +1,3 @@
+{
+  "plugins": ["external-helpers", "transform-es2015-function-name"]
+}