cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Treat "await" as an invalid identifier (#4954)

Browse Source 
It is valid (outside `async` functions) in the "script" parse goal, but always invalid in the "module" parse goal.

Fixes #4952.
This commit is contained in:
Diogo Franco 2017-03-19 11:28:52 +09:00 committed by GitHub
parent 8859715893
commit 256fcbc58f
4 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
packages/babel-plugin-transform-es2015-function-name/test/fixtures/function-name/await/actual.js vendored Normal file
View File

@ -0,0 +1,3 @@
export {};
var obj = { await: function () {} };

3
packages/babel-plugin-transform-es2015-function-name/test/fixtures/function-name/await/expected.js vendored Normal file
View File

@ -0,0 +1,3 @@
export {};
var obj = { await: function _await() {} };

3
packages/babel-types/src/validators.js
View File

@ -167,6 +167,9 @@ export function isReferenced(node: Object, parent: Object): boolean {
export function isValidIdentifier(name: string): boolean { export function isValidIdentifier(name: string): boolean {
if (typeof name !== "string" || esutils.keyword.isReservedWordES6(name, true)) { if (typeof name !== "string" || esutils.keyword.isReservedWordES6(name, true)) {
return false; return false;
} else if (name === "await") {
// invalid in module, valid in script; better be safe (see #4952)
return false;
} else { } else {
return esutils.keyword.isIdentifierNameES6(name); return esutils.keyword.isIdentifierNameES6(name);
} }

4
packages/babel-types/test/validators.js
View File

@ -26,5 +26,9 @@ suite("validators", function () {
assert(t.isNodesEquivalent(parse(program), parse(program2)) === false); assert(t.isNodesEquivalent(parse(program), parse(program2)) === false);
}); });
it("rejects 'await' as an identifier", function () {
assert(t.isValidIdentifier("await") === false);
});
}); });
}); });