cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Refactor parseSubscript (#10937)

Browse Source 
* refactor: unify optionalMemberExpression generation

* test: add optional calls invalid typecasts

* fix: do not parse async arrow when call is optional

* test: update test fixtures
This commit is contained in:
Huáng Jùnliàng
2019-12-30 16:11:39 -05:00
committed by GitHub
parent 86245a83a2
commit 30449fe05d
6 changed files with 219 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
packages/babel-parser/test/fixtures/flow/typecasts/fail-in-async-optional-calls/input.js vendored Normal file
View File

@@ -0,0 +1 @@
async?.(bar: string) => {}

8
packages/babel-parser/test/fixtures/flow/typecasts/fail-in-async-optional-calls/options.json vendored Normal file
View File

@@ -0,0 +1,8 @@
{
"sourceType": "module",
"plugins": [
"flow",
"optionalChaining"
],
"throws": "Unexpected token, expected \";\" (1:21)"
}

1
packages/babel-parser/test/fixtures/flow/typecasts/fail-in-optional-calls/input.js vendored Normal file
View File

@@ -0,0 +1 @@
funccall?.(a, b: string);

7
packages/babel-parser/test/fixtures/flow/typecasts/fail-in-optional-calls/options.json vendored Normal file
View File

@@ -0,0 +1,7 @@
{
"sourceType": "module",
"plugins": [
"flow",
"optionalChaining"
]
}

167
packages/babel-parser/test/fixtures/flow/typecasts/fail-in-optional-calls/output.json vendored Normal file
View File

@@ -0,0 +1,167 @@
{
"type": "File",
"start": 0,
"end": 25,
"loc": {
"start": {
"line": 1,
"column": 0
},
"end": {
"line": 1,
"column": 25
}
},
"errors": [
"SyntaxError: The type cast expression is expected to be wrapped with parenthesis (1:15)"
],
"program": {
"type": "Program",
"start": 0,
"end": 25,
"loc": {
"start": {
"line": 1,
"column": 0
},
"end": {
"line": 1,
"column": 25
}
},
"sourceType": "module",
"interpreter": null,
"body": [
{
"type": "ExpressionStatement",
"start": 0,
"end": 25,
"loc": {
"start": {
"line": 1,
"column": 0
},
"end": {
"line": 1,
"column": 25
}
},
"expression": {
"type": "OptionalCallExpression",
"start": 0,
"end": 24,
"loc": {
"start": {
"line": 1,
"column": 0
},
"end": {
"line": 1,
"column": 24
}
},
"callee": {
"type": "Identifier",
"start": 0,
"end": 8,
"loc": {
"start": {
"line": 1,
"column": 0
},
"end": {
"line": 1,
"column": 8
},
"identifierName": "funccall"
},
"name": "funccall"
},
"optional": true,
"arguments": [
{
"type": "Identifier",
"start": 11,
"end": 12,
"loc": {
"start": {
"line": 1,
"column": 11
},
"end": {
"line": 1,
"column": 12
},
"identifierName": "a"
},
"name": "a"
},
{
"type": "TypeCastExpression",
"start": 14,
"end": 23,
"loc": {
"start": {
"line": 1,
"column": 14
},
"end": {
"line": 1,
"column": 23
}
},
"expression": {
"type": "Identifier",
"start": 14,
"end": 15,
"loc": {
"start": {
"line": 1,
"column": 14
},
"end": {
"line": 1,
"column": 15
},
"identifierName": "b"
},
"name": "b"
},
"typeAnnotation": {
"type": "TypeAnnotation",
"start": 15,
"end": 23,
"loc": {
"start": {
"line": 1,
"column": 15
},
"end": {
"line": 1,
"column": 23
}
},
"typeAnnotation": {
"type": "StringTypeAnnotation",
"start": 17,
"end": 23,
"loc": {
"start": {
"line": 1,
"column": 17
},
"end": {
"line": 1,
"column": 23
}
}
}
}
}
]
}
}
],
"directives": []
}
}