Not null check in babel-helper-builder-binary-assignment-operator-visitor (#3647)

Fix: T7537 — https://phabricator.babeljs.io/T7537

When transforming super call in class constructor, part of ast is replaced using method "replaceWithMultiple" here:
https://github.com/babel/babel/blob/master/packages/babel-plugin-transform-es2015-classes/src/vanilla.js#L379

It leads to removing the node (replacing it with null) here:
https://github.com/babel/babel/blob/master/packages/babel-traverse/src/path/replacement.js#L51

But parent ExpressionsStatement is still untouched and when it reaches visitor generated in here
https://github.com/babel/babel/blob/master/packages/babel-helper-builder-binary-assignment-operator-visitor/src/index.js#L18

It blows up because expression is null from previous visitors.
This commit is contained in:
Stanislav Sysoev
2016-08-31 21:41:49 +03:00
committed by Henry Zhu
parent 4ac0df00f1
commit 33da726638
4 changed files with 43 additions and 1 deletions

View File

@@ -0,0 +1,7 @@
class B{}
class A extends B{
constructor(track){
if (track !== undefined) super(track);
else super();
}
}

View File

@@ -0,0 +1,31 @@
"use strict";
function _possibleConstructorReturn(self, call) { if (!self) { throw new ReferenceError("this hasn't been initialised - super() hasn't been called"); } return call && (typeof call === "object" || typeof call === "function") ? call : self; }
function _inherits(subClass, superClass) { if (typeof superClass !== "function" && superClass !== null) { throw new TypeError("Super expression must either be null or a function, not " + typeof superClass); } subClass.prototype = Object.create(superClass && superClass.prototype, { constructor: { value: subClass, enumerable: false, writable: true, configurable: true } }); if (superClass) Object.setPrototypeOf ? Object.setPrototypeOf(subClass, superClass) : subClass.__proto__ = superClass; }
function _classCallCheck(instance, Constructor) { if (!(instance instanceof Constructor)) { throw new TypeError("Cannot call a class as a function"); } }
var B = function B() {
_classCallCheck(this, B);
};
var A = function (_B) {
_inherits(A, _B);
function A(track) {
_classCallCheck(this, A);
if (track !== undefined) {
;
var _this = _possibleConstructorReturn(this, Object.getPrototypeOf(A).call(this, track));
} else {
;
var _this = _possibleConstructorReturn(this, Object.getPrototypeOf(A).call(this));
}return _possibleConstructorReturn(_this);
}
return A;
}(B);

View File

@@ -0,0 +1,4 @@
{
"plugins": ["transform-exponentiation-operator"],
"presets": ["es2015"]
}