From 3d69dc9471c4eb235ddd1971fd15cc251149edbc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nicol=C3=B2=20Ribaudo?= Date: Fri, 29 Jan 2021 17:58:13 +0100 Subject: [PATCH] Add `#` to the private name in "write-only" errors (#12713) --- .../babel-helper-create-class-features-plugin/src/fields.js | 2 +- .../test/fixtures/accessors/get-only-setter/output.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/babel-helper-create-class-features-plugin/src/fields.js b/packages/babel-helper-create-class-features-plugin/src/fields.js index 0c4631ba12..aca3cfa755 100644 --- a/packages/babel-helper-create-class-features-plugin/src/fields.js +++ b/packages/babel-helper-create-class-features-plugin/src/fields.js @@ -228,7 +228,7 @@ const privateNameHandlerSpec = { if (!getId && setId) { if (file.availableHelper("writeOnlyError")) { return t.callExpression(file.addHelper("writeOnlyError"), [ - t.stringLiteral(name), + t.stringLiteral(`#${name}`), ]); } console.warn( diff --git a/packages/babel-plugin-proposal-private-methods/test/fixtures/accessors/get-only-setter/output.js b/packages/babel-plugin-proposal-private-methods/test/fixtures/accessors/get-only-setter/output.js index d49c3805ad..723c7b1459 100644 --- a/packages/babel-plugin-proposal-private-methods/test/fixtures/accessors/get-only-setter/output.js +++ b/packages/babel-plugin-proposal-private-methods/test/fixtures/accessors/get-only-setter/output.js @@ -14,7 +14,7 @@ class Cl { value: 0 }); - this.publicField = babelHelpers.writeOnlyError("privateFieldValue"); + this.publicField = babelHelpers.writeOnlyError("#privateFieldValue"); } }