cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Clean up traverse scope (#12797)

Browse Source
This commit is contained in:
Huáng Jùnliàng
2021-02-16 17:23:34 -05:00
committed by GitHub
parent 4819ce70e4
commit 4462eeae6b
3 changed files with 140 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
packages/babel-traverse/test/__snapshots__/scope.js.snap
View File

@@ -4,12 +4,16 @@ exports[`scope duplicate bindings catch const 1`] = `"Duplicate declaration \\"e
exports[`scope duplicate bindings catch let 1`] = `"Duplicate declaration \\"e\\""`;
exports[`scope duplicate bindings global class/class 1`] = `"Duplicate declaration \\"foo\\""`;
exports[`scope duplicate bindings global class/const 1`] = `"Duplicate declaration \\"foo\\""`;
exports[`scope duplicate bindings global class/function 1`] = `"Duplicate declaration \\"foo\\""`;
exports[`scope duplicate bindings global class/let 1`] = `"Duplicate declaration \\"foo\\""`;
exports[`scope duplicate bindings global class/var 1`] = `"Duplicate declaration \\"foo\\""`;
exports[`scope duplicate bindings global const/class 1`] = `"Duplicate declaration \\"foo\\""`;
exports[`scope duplicate bindings global const/const 1`] = `"Duplicate declaration \\"foo\\""`;
@@ -34,4 +38,6 @@ exports[`scope duplicate bindings global let/let 1`] = `"Duplicate declaration \
exports[`scope duplicate bindings global let/var 1`] = `"Duplicate declaration \\"foo\\""`;
exports[`scope duplicate bindings global var/class 1`] = `"Duplicate declaration \\"foo\\""`;
exports[`scope duplicate bindings global var/let 1`] = `"Duplicate declaration \\"foo\\""`;

119
packages/babel-traverse/test/scope.js
View File

@@ -2,7 +2,7 @@ import traverse, { NodePath } from "../lib";
import { parse } from "@babel/parser";
import * as t from "@babel/types";
function getPath(code, options) {
function getPath(code, options): NodePath<t.Program> {
const ast =
typeof code === "string" ? parse(code, options) : createNode(code);
let path;
@@ -92,6 +92,82 @@ describe("scope", () => {
});
});
describe("import declaration", () => {
it.each([
[
"import default",
"import foo from 'foo';(foo)=>{}",
"foo",
"ImportDefaultSpecifier",
],
[
"import named default",
"import { default as foo } from 'foo';(foo)=>{}",
"foo",
"ImportSpecifier",
],
[
"import named",
"import { foo } from 'foo';(foo)=>{}",
"foo",
"ImportSpecifier",
],
[
"import named aliased",
"import { _foo as foo } from 'foo';(foo)=>{}",
"foo",
"ImportSpecifier",
],
[
"import namespace",
"import * as foo from 'foo';(foo)=>{}",
"foo",
"ImportNamespaceSpecifier",
],
])("%s", (testTitle, source, bindingName, bindingNodeType) => {
expect(
getPath(source, { sourceType: "module" }).scope.getBinding(
bindingName,
).path.type,
).toBe(bindingNodeType);
});
});
describe("export declaration", () => {
it.each([
[
"export default function",
"export default function foo(foo) {}",
"foo",
"FunctionDeclaration",
],
[
"export default class",
"export default class foo extends function foo () {} {}",
"foo",
"ClassDeclaration",
],
[
"export named default",
"export const foo = function foo(foo) {};",
"foo",
"VariableDeclarator",
],
[
"export named default",
"export const [ { foo } ] = function foo(foo) {};",
"foo",
"VariableDeclarator",
],
])("%s", (testTitle, source, bindingName, bindingNodeType) => {
expect(
getPath(source, { sourceType: "module" }).scope.getBinding(
bindingName,
).path.type,
).toBe(bindingNodeType);
});
});
it("variable declaration", function () {
expect(getPath("var foo = null;").scope.getBinding("foo").path.type).toBe(
"VariableDeclarator",
@@ -284,6 +360,41 @@ describe("scope", () => {
});
});
describe("after crawl", () => {
it("modified function identifier available in function scope", () => {
const path = getPath("(function f(f) {})")
.get("body")[0]
.get("expression");
path.get("id").replaceWith(t.identifier("g"));
path.scope.crawl();
const binding = path.scope.getBinding("g");
expect(binding.kind).toBe("local");
});
it("modified function param available in function scope", () => {
const path = getPath("(function f(f) {})")
.get("body")[0]
.get("expression");
path.get("params")[0].replaceWith(t.identifier("g"));
path.scope.crawl();
const binding = path.scope.getBinding("g");
expect(binding.kind).toBe("param");
});
it("modified class identifier available in class expression scope", () => {
const path = getPath("(class c {})").get("body")[0].get("expression");
path.get("id").replaceWith(t.identifier("g"));
path.scope.crawl();
const binding = path.scope.getBinding("g");
expect(binding.kind).toBe("local");
});
it("modified class identifier available in class declaration scope", () => {
const path = getPath("class c {}").get("body")[0];
path.get("id").replaceWith(t.identifier("g"));
path.scope.crawl();
const binding = path.scope.getBinding("g");
expect(binding.kind).toBe("let");
});
});
it("class identifier available in class scope after crawl", function () {
const path = getPath("class a { build() { return new a(); } }");
@@ -421,7 +532,6 @@ describe("scope", () => {
// unless node1 === node2
const cases = [
["const", "let", false],
["const", "const", false],
["const", "function", false],
["const", "class", false],
@@ -432,11 +542,14 @@ describe("scope", () => {
["let", "function", false],
["let", "var", false],
//["var", "class", true],
["var", "class", false],
["var", "function", true],
["var", "var", true],
["class", "function", false],
["class", "class", false],
["function", "function", true],
];
const createNode = function (kind) {