Mark wrapNativeSuper and wrapRegExp as pure (#11134)

This commit is contained in:
Nicolò Ribaudo 2020-02-21 09:15:59 +01:00 committed by GitHub
parent a583eab41f
commit 4b045819b8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
9 changed files with 24 additions and 17 deletions

View File

@ -18,6 +18,7 @@
"babel-plugin"
],
"dependencies": {
"@babel/helper-annotate-as-pure": "^7.8.3",
"@babel/helper-regex": "^7.8.3",
"regexpu-core": "^4.6.0"
},

View File

@ -11,6 +11,7 @@ import { generateRegexpuOptions } from "./util";
import pkg from "../package.json";
import { types as t } from "@babel/core";
import { pullFlag } from "@babel/helper-regex";
import annotateAsPure from "@babel/helper-annotate-as-pure";
// Note: Versions are represented as an integer. e.g. 7.1.5 is represented
// as 70000100005. This method is easier than using a semver-parsing
@ -68,12 +69,13 @@ export function createRegExpFeaturePlugin({ name, feature, options = {} }) {
runtime &&
!isRegExpTest(path)
) {
path.replaceWith(
t.callExpression(this.addHelper("wrapRegExp"), [
node,
t.valueToNode(namedCaptureGroups),
]),
);
const call = t.callExpression(this.addHelper("wrapRegExp"), [
node,
t.valueToNode(namedCaptureGroups),
]);
annotateAsPure(call);
path.replaceWith(call);
}
if (hasFeature(features, FEATURES.unicodeFlag)) {
pullFlag(node, "u");

View File

@ -6,6 +6,7 @@ import ReplaceSupers, {
import optimiseCall from "@babel/helper-optimise-call-expression";
import * as defineMap from "@babel/helper-define-map";
import { traverse, template, types as t } from "@babel/core";
import annotateAsPure from "@babel/helper-annotate-as-pure";
type ReadonlySet<T> = Set<T> | { has(val: T): boolean };
@ -565,11 +566,14 @@ export default function transformClass(
const closureArgs = [];
if (classState.isDerived) {
const arg = classState.extendsNative
? t.callExpression(classState.file.addHelper("wrapNativeSuper"), [
t.cloneNode(superName),
])
: t.cloneNode(superName);
let arg = t.cloneNode(superName);
if (classState.extendsNative) {
arg = t.callExpression(classState.file.addHelper("wrapNativeSuper"), [
arg,
]);
annotateAsPure(arg);
}
const param = classState.scope.generateUidIdentifierBasedOnNode(
superName,
);

View File

@ -22,4 +22,4 @@ var List = /*#__PURE__*/function (_Array) {
}
return List;
}(_wrapNativeSuper(Array));
}( /*#__PURE__*/_wrapNativeSuper(Array));

View File

@ -30,4 +30,4 @@ var List = /*#__PURE__*/function (_Array) {
}
return List;
}(_wrapNativeSuper(Array));
}( /*#__PURE__*/_wrapNativeSuper(Array));

View File

@ -20,7 +20,7 @@ var CustomElement = /*#__PURE__*/function (_HTMLElement) {
}
return CustomElement;
}(babelHelpers.wrapNativeSuper(HTMLElement));
}( /*#__PURE__*/babelHelpers.wrapNativeSuper(HTMLElement));
;
new CustomElement();

View File

@ -1,3 +1,3 @@
"foo".match(babelHelpers.wrapRegExp(/(.)\1/, {
"foo".match( /*#__PURE__*/babelHelpers.wrapRegExp(/(.)\1/, {
double: 1
}));

View File

@ -1,3 +1,3 @@
"abba".match(babelHelpers.wrapRegExp(/(.)(.)\2\1/, {
"abba".match( /*#__PURE__*/babelHelpers.wrapRegExp(/(.)(.)\2\1/, {
n: 2
}));

View File

@ -32,6 +32,6 @@ var MyDate = /*#__PURE__*/function (_Date) {
}
return MyDate;
}(_wrapNativeSuper(Date));
}( /*#__PURE__*/_wrapNativeSuper(Date));
var myDate = new MyDate();