cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

minor improvement to gulp generate-runtime-helpers error message (#13522)

Browse Source 
* improve gulp generate-runtime-helpers error message

If you had some garbage in packages/babel-runtime-helpers/src/helpers/,
gulp generate-runtime-helpers would blow up with an unhelpful message:

    TypeError: Cannot read property 'groups' of null

* ignore files starting with a dot when generating runtime helpers
This commit is contained in:
Mickey Rose 2021-07-02 15:12:19 +02:00 committed by GitHub
parent 9bad558d13
commit 4ee78eb3f1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
packages/babel-helpers/scripts/generate-helpers.js
View File

@ -17,18 +17,21 @@ import template from "@babel/template";
for (const file of (await fs.promises.readdir(HELPERS_FOLDER)).sort()) { for (const file of (await fs.promises.readdir(HELPERS_FOLDER)).sort()) {
if (IGNORED_FILES.has(file)) continue; if (IGNORED_FILES.has(file)) continue;
if (file.startsWith(".")) continue; // ignore e.g. vim swap files
const [helperName] = file.split("."); const [helperName] = file.split(".");
const isValidId = isValidBindingIdentifier(helperName); const isValidId = isValidBindingIdentifier(helperName);
const varName = isValidId ? helperName : `_${helperName}`; const varName = isValidId ? helperName : `_${helperName}`;
const fileContents = await fs.promises.readFile( const filePath = join(fileURLToPath(HELPERS_FOLDER), file);
join(fileURLToPath(HELPERS_FOLDER), file), const fileContents = await fs.promises.readFile(filePath, "utf8");
"utf8" const minVersionMatch = fileContents.match(
);
const { minVersion } = fileContents.match(
/^\s*\/\*\s*@minVersion\s+(?<minVersion>\S+)\s*\*\/\s*$/m /^\s*\/\*\s*@minVersion\s+(?<minVersion>\S+)\s*\*\/\s*$/m
).groups; );
if (!minVersionMatch) {
throw new Error(`@minVersion number missing in ${filePath}`);
}
const { minVersion } = minVersionMatch.groups;
// TODO: We can minify the helpers in production // TODO: We can minify the helpers in production
const source = fileContents const source = fileContents