From 559d6499949e756fc0ce839db937c4167f7caf10 Mon Sep 17 00:00:00 2001
From: Daniel Tschinder <daniel@tschinder.de>
Date: Wed, 28 Nov 2018 12:36:24 -0800
Subject: [PATCH] Skip minifying standalone (#9094)

Also remove unused dependency on uglify js. gulp-uglify uses its own version.
---
 Makefile              |  2 +-
 package.json          |  1 -
 scripts/gulp-tasks.js | 32 ++++++++++++++++++++++++++++++--
 yarn.lock             |  2 +-
 4 files changed, 32 insertions(+), 5 deletions(-)

diff --git a/Makefile b/Makefile
index 8b83524e14..d1032af00d 100644
--- a/Makefile
+++ b/Makefile
@@ -115,7 +115,7 @@ prepublish-build:
 	rm -rf packages/babel-runtime/helpers
 	rm -rf packages/babel-runtime-corejs2/helpers
 	rm -rf packages/babel-runtime-corejs2/core-js
-	BABEL_ENV=production make build-dist
+	BABEL_ENV=production IS_PUBLISH=true make build-dist
 	make clone-license
 
 prepublish:
diff --git a/package.json b/package.json
index 426bbe9725..6f5e974d98 100644
--- a/package.json
+++ b/package.json
@@ -63,7 +63,6 @@
     "rollup-stream": "^1.24.1",
     "test262-stream": "^1.2.0",
     "through2": "^2.0.0",
-    "uglify-js": "^2.4.16",
     "vinyl-buffer": "^1.0.1",
     "vinyl-source-stream": "^2.0.0",
     "webpack": "^3.4.1",
diff --git a/scripts/gulp-tasks.js b/scripts/gulp-tasks.js
index f3c696de50..e22b13c873 100644
--- a/scripts/gulp-tasks.js
+++ b/scripts/gulp-tasks.js
@@ -13,6 +13,9 @@
 
 const path = require("path");
 const pump = require("pump");
+const chalk = require("chalk");
+const through = require("through2");
+const gutil = require("gulp-util");
 const rename = require("gulp-rename");
 const RootMostResolvePlugin = require("webpack-dependency-suite")
   .RootMostResolvePlugin;
@@ -94,6 +97,30 @@ function webpackBuild(opts) {
   });*/
 }
 
+function logUglify() {
+  return through.obj(function(file, enc, callback) {
+    gutil.log(
+      `Minifying '${chalk.cyan(
+        path.relative(path.join(__dirname, ".."), file.path)
+      )}'...`
+    );
+    callback(null, file);
+  });
+}
+
+function logNoUglify() {
+  return through.obj(function(file, enc, callback) {
+    gutil.log(
+      chalk.yellow(
+        `Skipped minification of '${chalk.cyan(
+          path.relative(path.join(__dirname, ".."), file.path)
+        )}' because not publishing`
+      )
+    );
+    callback(null, file);
+  });
+}
+
 function registerStandalonePackageTask(
   gulp,
   name,
@@ -116,8 +143,9 @@ function registerStandalonePackageTask(
         }),
         gulp.dest(standalonePath),
       ].concat(
-        // Minification is super slow, so we skip it in CI.
-        process.env.CI ? [] : uglify(),
+        // Minification is super slow, so we skip it unless we are publishing
+        process.env.IS_PUBLISH ? logUglify() : logNoUglify(),
+        process.env.IS_PUBLISH ? uglify() : [],
         rename({ extname: ".min.js" }),
         gulp.dest(standalonePath)
       ),
diff --git a/yarn.lock b/yarn.lock
index 4a53a71c1f..769ac3f600 100644
--- a/yarn.lock
+++ b/yarn.lock
@@ -9357,7 +9357,7 @@ uglify-js@3.3.x, uglify-js@^3.0.5:
     commander "~2.14.1"
     source-map "~0.6.1"
 
-uglify-js@^2.4.16, uglify-js@^2.6, uglify-js@^2.8.29:
+uglify-js@^2.6, uglify-js@^2.8.29:
   version "2.8.29"
   resolved "https://registry.yarnpkg.com/uglify-js/-/uglify-js-2.8.29.tgz#29c5733148057bb4e1f75df35b7a9cb72e6a59dd"
   integrity sha1-KcVzMUgFe7Th913zW3qcty5qWd0=