cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

add aliases to plugins that are where they were first specified for performance

Browse Source
This commit is contained in:
Sebastian McKenzie 2015-11-13 16:54:47 -08:00
parent 5b6a39f227
commit 5cb326a7f6
2 changed files with 23 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
packages/babel-core/src/transformation/file/options/option-manager.js
View File

@ -32,6 +32,19 @@ function exists(filename) {
}
}
type PluginObject = {
pre?: Function;
post?: Function;
manipulateOptions?: Function;
visitor: ?{
[key: string]: Function | {
enter?: Function | Array<Function>;
exit?: Function | Array<Function>;
}
};
};
export default class OptionManager {
constructor(log?: Logger) {
this.resolvedConfigs = [];
@ -48,12 +61,12 @@ export default class OptionManager {
plugin: Plugin;
}>;
static memoisePluginContainer(fn, loc, i) {
static memoisePluginContainer(fn, loc, i, alias) {
for (let cache of (OptionManager.memoisedPlugins: Array<Object>)) {
if (cache.container === fn) return cache.plugin;
}
let obj;
let obj: ?PluginObject;
if (typeof fn === "function") {
obj = fn(context);
@ -62,7 +75,7 @@ export default class OptionManager {
}
if (typeof obj === "object") {
let plugin = new Plugin(obj);
let plugin = new Plugin(obj, alias);
OptionManager.memoisedPlugins.push({
container: fn,
plugin: plugin
@ -84,13 +97,13 @@ export default class OptionManager {
return opts;
}
static normalisePlugin(plugin, loc, i) {
static normalisePlugin(plugin, loc, i, alias) {
plugin = plugin.__esModule ? plugin.default : plugin;
if (!(plugin instanceof Plugin)) {
// allow plugin containers to be specified so they don't have to manually require
if (typeof plugin === "function" || typeof plugin === "object") {
plugin = OptionManager.memoisePluginContainer(plugin, loc, i);
plugin = OptionManager.memoisePluginContainer(plugin, loc, i, alias);
} else {
throw new TypeError(messages.get("pluginNotFunction", loc, i, typeof plugin));
}
@ -112,6 +125,8 @@ export default class OptionManager {
plugin = val;
}
let alias = typeof plugin === "string" ? plugin : `${loc}$${i}`;
// allow plugins to be specified as strings
if (typeof plugin === "string") {
let pluginLoc = resolve(`babel-plugin-${plugin}`, dirname) || resolve(plugin, dirname);
@ -122,7 +137,7 @@ export default class OptionManager {
}
}
plugin = OptionManager.normalisePlugin(plugin, loc, i);
plugin = OptionManager.normalisePlugin(plugin, loc, i, alias);
return [plugin, options];
});

3
packages/babel-core/src/transformation/plugin.js
View File

@ -10,11 +10,12 @@ import clone from "lodash/lang/clone";
const GLOBAL_VISITOR_PROPS = ["enter", "exit"];
export default class Plugin extends Store {
constructor(plugin: Object) {
constructor(plugin: Object, key?: string) {
super();
this.initialized = false;
this.raw = assign({}, plugin);
this.key = key;
this.manipulateOptions = this.take("manipulateOptions");
this.post = this.take("post");