cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

polish: skip creating extra reference for safely re-used node (#10720)

Browse Source 
* polish: skip creating extra reference for safely re-used node

* reimplement using scope.maybeGenerateMemoised
This commit is contained in:
Huáng Jùnliàng 2019-11-15 19:11:03 -05:00 committed by Nicolò Ribaudo
parent d56911b88d
commit 6c7f8291d4
9 changed files with 26 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
packages/babel-plugin-proposal-nullish-coalescing-operator/src/index.js
View File

@ -16,14 +16,15 @@ export default declare((api, { loose = false }) => {
return;
}
const ref = scope.generateUidIdentifierBasedOnNode(node.left);
scope.push({ id: ref });
const assignment = t.assignmentExpression(
"=",
t.cloneNode(ref),
node.left,
);
let ref = scope.maybeGenerateMemoised(node.left);
let assignment;
// skip creating extra reference when `left` is static
if (ref === null) {
ref = node.left;
assignment = t.cloneNode(node.left);
} else {
assignment = t.assignmentExpression("=", ref, node.left);
}
path.replaceWith(
t.conditionalExpression(

2
packages/babel-plugin-proposal-nullish-coalescing-operator/test/fixtures/nullish-coalescing/transform-in-default/input.js vendored
View File

@ -1 +1 @@
function foo(foo, bar = foo ?? "bar") {}
function foo(foo, qux = foo.bar ?? "qux") {}

4
packages/babel-plugin-proposal-nullish-coalescing-operator/test/fixtures/nullish-coalescing/transform-in-default/output.js vendored
View File

@ -1,3 +1,3 @@
function foo(foo, bar = (_foo = foo) !== null && _foo !== void 0 ? _foo : "bar") {
var _foo;
function foo(foo, qux = (_foo$bar = foo.bar) !== null && _foo$bar !== void 0 ? _foo$bar : "qux") {
var _foo$bar;
}

1
packages/babel-plugin-proposal-nullish-coalescing-operator/test/fixtures/nullish-coalescing/transform-static-refs-in-default/input.js vendored Normal file
View File

@ -0,0 +1 @@
function foo(foo, bar = foo ?? "bar") {}

3
packages/babel-plugin-proposal-nullish-coalescing-operator/test/fixtures/nullish-coalescing/transform-static-refs-in-default/options.json vendored Normal file
View File

@ -0,0 +1,3 @@
{
"plugins": ["proposal-nullish-coalescing-operator"]
}

1
packages/babel-plugin-proposal-nullish-coalescing-operator/test/fixtures/nullish-coalescing/transform-static-refs-in-default/output.js vendored Normal file
View File

@ -0,0 +1 @@
function foo(foo, bar = foo !== null && foo !== void 0 ? foo : "bar") {}

3
packages/babel-plugin-proposal-nullish-coalescing-operator/test/fixtures/nullish-coalescing/transform-static-refs-in-function/input.js vendored Normal file
View File

@ -0,0 +1,3 @@
function foo() {
var foo = this ?? {};
}

3
packages/babel-plugin-proposal-nullish-coalescing-operator/test/fixtures/nullish-coalescing/transform-static-refs-in-function/options.json vendored Normal file
View File

@ -0,0 +1,3 @@
{
"plugins": ["proposal-nullish-coalescing-operator"]
}

3
packages/babel-plugin-proposal-nullish-coalescing-operator/test/fixtures/nullish-coalescing/transform-static-refs-in-function/output.js vendored Normal file
View File

@ -0,0 +1,3 @@
function foo() {
var foo = this !== null && this !== void 0 ? this : {};
}