class private methods and properties: should not allow spaces between # and identifier (#8756)

packages/babel-parser/src/parser/expression.js

@@ -923,7 +923,19 @@ export default class ExpressionParser extends LValParser {
     if (isPrivate) {
       this.expectOnePlugin(["classPrivateProperties", "classPrivateMethods"]);
       const node = this.startNode();
+      const columnHashEnd = this.state.end;
       this.next();
+      const columnIdentifierStart = this.state.start;
+
+      const spacesBetweenHashAndIdentifier =
+        columnIdentifierStart - columnHashEnd;
+      if (spacesBetweenHashAndIdentifier != 0) {
+        this.raise(
+          columnIdentifierStart,
+          "Unexpected space between # and identifier",
+        );
+      }
+
       node.id = this.parseIdentifier(true);
       return this.finishNode(node, "PrivateName");
     } else {

packages/babel-parser/test/fixtures/experimental/class-private-methods/failure-spaces/input.js

@@ -0,0 +1,5 @@
+class Spaces {
+  #  wrongSpaces() {
+    return fail();
+  }
+}

packages/babel-parser/test/fixtures/experimental/class-private-methods/failure-spaces/options.json

@@ -0,0 +1,4 @@
+{
+  "throws": "Unexpected space between # and identifier (2:5)",
+  "plugins": ["classPrivateMethods"]
+}

packages/babel-parser/test/fixtures/experimental/class-private-properties/failure-spaces/input.js

@@ -0,0 +1,3 @@
+class Spaces {
+  #  wrongSpaces;
+}

packages/babel-parser/test/fixtures/experimental/class-private-properties/failure-spaces/options.json

@@ -0,0 +1,4 @@
+{
+  "throws": "Unexpected space between # and identifier (2:5)",
+  "plugins": ["classPrivateMethods"]
+}