Throw a better error when transforming imported bindings in types (#13739)

* Throw a better error when transforming imported bindings in types

* Also type casts

* Update error message
This commit is contained in:
Nicolò Ribaudo
2021-09-16 23:14:41 +02:00
committed by GitHub
parent 2ffb19828f
commit 8fb50429ea
15 changed files with 97 additions and 0 deletions

View File

@@ -44,6 +44,25 @@ interface RewriteBindingInitVisitorState {
scope: Scope;
}
function isInType(path) {
do {
switch (path.parent.type) {
case "TSTypeAnnotation":
case "TSTypeAliasDeclaration":
case "TSTypeReference":
case "TypeAnnotation":
case "TypeAlias":
return true;
case "ExportSpecifier":
return path.parentPath.parent.exportKind === "type";
default:
if (path.parentPath.isStatement() || path.parentPath.isExpression()) {
return false;
}
}
} while ((path = path.parentPath));
}
export default function rewriteLiveReferences(
programPath: NodePath<t.Program>,
metadata: ModuleMetadata,
@@ -224,6 +243,13 @@ const rewriteReferencesVisitor: Visitor<RewriteReferencesVisitorState> = {
const importData = imported.get(localName);
if (importData) {
if (isInType(path)) {
throw path.buildCodeFrameError(
`Cannot transform the imported binding "${localName}" since it's also used in a type annotation. ` +
`Please strip type annotations using @babel/preset-typescript or @babel/preset-flow.`,
);
}
const localBinding = path.scope.getBinding(localName);
const rootBinding = scope.getBinding(localName);