[@babel/cli] Copy ignored files by default (#11063)

This commit restores the pre-7.8.0 behavior of the --copy-files option, by making
--copy-ignored default to true when --copy-files is enabled.

packages/babel-cli/src/babel/options.js

@@ -140,6 +140,7 @@ commander.option(
   "--relative",
   "Compile into an output directory relative to input directory or file. Requires --out-dir [out]",
 );
+
 commander.option(
   "-D, --copy-files",
   "When compiling a directory copy over non-compilable files.",
@@ -148,6 +149,11 @@ commander.option(
   "--include-dotfiles",
   "Include dotfiles when compiling and copying non-compilable files.",
 );
+commander.option(
+  "--no-copy-ignored",
+  "Exclude ignored files when copying non-compilable files.",
+);
+
 commander.option(
   "--verbose",
   "Log everything. This option conflicts with --quiet",
@@ -165,11 +171,6 @@ commander.option(
   "Use a specific extension for the output files",
 );
 
-commander.option(
-  "--copy-ignored",
-  "Include ignored files when copying non-compilable files.",
-);
-
 commander.version(pkg.version + " (@babel/core " + version + ")");
 commander.usage("[options] <files ...>");
 // register an empty action handler so that commander.js can throw on
@@ -315,12 +316,12 @@ export default function parseArgv(args: Array<string>): CmdOptions | null {
       outDir: opts.outDir,
       relative: opts.relative,
       copyFiles: opts.copyFiles,
+      copyIgnored: opts.copyFiles && opts.copyIgnored,
       includeDotfiles: opts.includeDotfiles,
       verbose: opts.verbose,
       quiet: opts.quiet,
       deleteDirOnStart: opts.deleteDirOnStart,
       sourceMapTarget: opts.sourceMapTarget,
-      copyIgnored: opts.copyIgnored,
     },
   };
 }

packages/babel-cli/test/fixtures/babel/--copy-files --include-dotfiles with ignore in babelrc/out-files/lib/foo/.foo.js

@@ -0,0 +1 @@
+a;

packages/babel-cli/test/fixtures/babel/--copy-files --include-dotfiles with ignore/out-files/lib/foo/.foo.js

@@ -0,0 +1 @@
+a;

packages/babel-cli/test/fixtures/babel/--copy-files --include-dotfiles/out-files/lib/foo/foo.js

@@ -0,0 +1 @@
+"use strict";

packages/babel-cli/test/fixtures/babel/--copy-files --no-copy-ignored with babelignore/options.json

@@ -4,7 +4,7 @@
     "--out-dir",
     "lib",
     "--copy-files",
-    "--copy-ignored",
+    "--no-copy-ignored",
     "--verbose"
   ]
 }

packages/babel-cli/test/fixtures/babel/--copy-files --no-copy-ignored with ignore in babelrc/options.json

@@ -4,7 +4,7 @@
     "--out-dir",
     "lib",
     "--copy-files",
-    "--copy-ignored",
+    "--no-copy-ignored",
     "--verbose"
   ]
 }

packages/babel-cli/test/fixtures/babel/--copy-files --no-copy-ignored with ignore/options.json

@@ -6,7 +6,7 @@
     "--copy-files",
     "--ignore",
     "src/foo",
-    "--copy-ignored",
+    "--no-copy-ignored",
     "--verbose"
   ]
 }

packages/babel-cli/test/fixtures/babel/--copy-files --no-copy-ignored with only/options.json

@@ -6,7 +6,7 @@
     "--copy-files",
     "--only",
     "src/foo/*",
-    "--copy-ignored",
+    "--no-copy-ignored",
     "--verbose"
   ]
 }

packages/babel-cli/test/fixtures/babel/--copy-files with ignore in babelrc/out-files/lib/foo/bar.js

@@ -0,0 +1 @@
+bar;

packages/babel-cli/test/fixtures/babel/--copy-files with ignore/out-files/lib/foo/bar.js

@@ -0,0 +1 @@
+bar;

packages/babel-cli/test/fixtures/babel/--copy-files with only/out-files/lib/index.js

@@ -0,0 +1 @@
+index;

packages/babel-cli/test/index.js

@@ -94,20 +94,21 @@ const assertTest = function(stdout, stderr, opts, cwd) {
     const actualFiles = readDir(tmpLoc, fileFilter);
 
     Object.keys(actualFiles).forEach(function(filename) {
-      if (
-        // saveInFiles always creates an empty .babelrc, so lets exclude for now
-        filename !== ".babelrc" &&
-        filename !== ".babelignore" &&
-        !Object.prototype.hasOwnProperty.call(opts.inFiles, filename)
-      ) {
-        const expected = opts.outFiles[filename];
-        const actual = actualFiles[filename];
+      try {
+        if (
+          // saveInFiles always creates an empty .babelrc, so lets exclude for now
+          filename !== ".babelrc" &&
+          filename !== ".babelignore" &&
+          !Object.prototype.hasOwnProperty.call(opts.inFiles, filename)
+        ) {
+          const expected = opts.outFiles[filename];
+          const actual = actualFiles[filename];
 
-        expect(expected).not.toBeUndefined();
-
-        if (expected) {
-          expect(actual).toBe(expected);
+          expect(actual).toBe(expected ?? "");
         }
+      } catch (e) {
+        e.message += "\n at " + filename;
+        throw e;
       }
     });