cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Set generator to true during error recovery of accessor (#11987)

Browse Source
This commit is contained in:
Brian Ng 2020-08-21 14:37:52 -05:00 committed by GitHub
parent b9407d7660
commit 941f610275
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
packages/babel-parser/src/parser/expression.js
View File

@ -1767,6 +1767,7 @@ export default class ExpressionParser extends LValParser {
isAccessor = true; isAccessor = true;
prop.kind = keyName; prop.kind = keyName;
if (this.match(tt.star)) { if (this.match(tt.star)) {
isGenerator = true;
this.raise(this.state.pos, Errors.AccessorIsGenerator, keyName); this.raise(this.state.pos, Errors.AccessorIsGenerator, keyName);
this.next(); this.next();
} }
@ -1827,7 +1828,9 @@ export default class ExpressionParser extends LValParser {
// isAccessor implies isAsync: false, isPattern: false, isGenerator: false // isAccessor implies isAsync: false, isPattern: false, isGenerator: false
this.parseMethod( this.parseMethod(
prop, prop,
/* isGenerator */ false, // This _should_ be false, but with error recovery, we allow it to be
// set for informational purposes
isGenerator,
/* isAsync */ false, /* isAsync */ false,
/* isConstructor */ false, /* isConstructor */ false,
false, false,

4
packages/babel-parser/test/fixtures/es2015/object/invalid-accessor-generator/output.json vendored
View File

@ -30,7 +30,7 @@
"computed": false, "computed": false,
"kind": "get", "kind": "get",
"id": null, "id": null,
"generator": false, "generator": true,
"async": false, "async": false,
"params": [], "params": [],
"body": { "body": {
@ -52,7 +52,7 @@
"computed": false, "computed": false,
"kind": "set", "kind": "set",
"id": null, "id": null,
"generator": false, "generator": true,
"async": false, "async": false,
"params": [ "params": [
{ {