cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Merge pull request #2811 from hzoo/i-2808

Browse Source 
transformation-react-inline-elements: ensure invalid identifier JSX attribute keys are quoted - fixes #2808
This commit is contained in:
Sebastian McKenzie 2015-11-04 19:16:32 +00:00
commit 9680bf6a68
3 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/babel-core/test/fixtures/transformation/optimisation.react.inline-elements/key/actual.js vendored
View File

@ -1 +1 @@
<Foo key="foo" /> <Foo key="foo" data-value="bar" />

6
packages/babel-core/test/fixtures/transformation/optimisation.react.inline-elements/key/expected.js vendored
View File

@ -3,6 +3,8 @@
type: Foo, type: Foo,
key: "foo", key: "foo",
ref: null, ref: null,
props: babelHelpers.defaultProps(Foo.defaultProps, {}), props: babelHelpers.defaultProps(Foo.defaultProps, {
"data-value": "bar"
}),
_owner: null _owner: null
}); });

4
packages/babel-plugin-transform-react-inline-elements/src/index.js
View File

@ -55,7 +55,9 @@ export default function ({ types: t }) {
if (isJSXAttributeOfName(attr, "key")) { if (isJSXAttributeOfName(attr, "key")) {
key = attr.value; key = attr.value;
} else { } else {
pushProp(props.properties, t.identifier(attr.name.name), attr.value || t.identifier("true")); let name = attr.name.name;
let propertyKey = t.isValidIdentifier(name) ? t.identifier(name) : t.stringLiteral(name);
pushProp(props.properties, propertyKey, attr.value || t.identifier("true"));
} }
} }