cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Make buildExportAll generate pure ES5 code.

Browse Source 
The untransformed `let` keyword causes problems for older parsers. I
understand using `let` instead of `var` ensures each getter function has
its own binding for the KEY variable, but the same can be accomplished
(with less code) using a `.forEach` callback function, and this way
there's no need to worry about generating a unique name for the `key`
variable.
This commit is contained in:
Ben Newman
2016-03-02 00:08:50 -05:00
parent f4197cc77b
commit 9acd33b93a
6 changed files with 30 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
packages/babel-plugin-transform-es2015-modules-commonjs/test/fixtures/interop/exports-from/expected.js vendored
View File

@@ -6,16 +6,15 @@ Object.defineProperty(exports, "__esModule", {
var _foo = require("foo");
for (let _key in _foo) {
if (_key === "default") continue;
Object.defineProperty(exports, _key, {
Object.keys(_foo).forEach(function (key) {
if (key === "default") return;
Object.defineProperty(exports, key, {
enumerable: true,
get: function () {
return _foo[_key];
return _foo[key];
}
});
}
});
Object.defineProperty(exports, "foo", {
enumerable: true,
get: function () {

16
packages/babel-plugin-transform-es2015-modules-commonjs/test/fixtures/regression/T7165/expected.js vendored
View File

@@ -6,21 +6,15 @@ Object.defineProperty(exports, "__esModule", {
var _bar = require('bar');
var _loop = function (_key2) {
if (_key2 === "default") return 'continue';
Object.defineProperty(exports, _key2, {
Object.keys(_bar).forEach(function (key) {
if (key === "default") return;
Object.defineProperty(exports, key, {
enumerable: true,
get: function () {
return _bar[_key2];
return _bar[key];
}
});
};
for (var _key2 in _bar) {
var _ret = _loop(_key2);
if (_ret === 'continue') continue;
}
});
var _foo = require('foo');

16
packages/babel-plugin-transform-es2015-modules-commonjs/test/fixtures/strict/export-all/expected.js vendored
View File

@@ -6,18 +6,12 @@ Object.defineProperty(exports, "__esModule", {
var _mod = require('mod');
var _loop = function (_key2) {
if (_key2 === "default") return 'continue';
Object.defineProperty(exports, _key2, {
Object.keys(_mod).forEach(function (key) {
if (key === "default") return;
Object.defineProperty(exports, key, {
enumerable: true,
get: function () {
return _mod[_key2];
return _mod[key];
}
});
};
for (var _key2 in _mod) {
var _ret = _loop(_key2);
if (_ret === 'continue') continue;
}
});