cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Better error for export * as ns without the correct plugin (#13296)

Browse Source
This commit is contained in:
Huáng Jùnliàng 2021-05-11 18:40:13 -04:00 committed by GitHub
parent cca97d1e78
commit 9e241fc180
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 28 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
packages/babel-helper-module-transforms/src/normalize-and-load-metadata.ts
View File

@ -189,6 +189,20 @@ function getExportSpecifierName(
}
}
function assertExportSpecifier(
path: NodePath,
): asserts path is NodePath<t.ExportSpecifier> {
if (path.isExportSpecifier()) {
return;
} else if (path.isExportNamespaceSpecifier()) {
throw path.buildCodeFrameError(
"Export namespace should be first transformed by `@babel/plugin-proposal-export-namespace-from`.",
);
} else {
throw path.buildCodeFrameError("Unexpected export specifier type");
}
}
/**
* Get metadata about the imports and exports present in this module.
*/
@ -307,9 +321,7 @@ function getModuleMetadata(
if (!data.loc) data.loc = child.node.loc;
child.get("specifiers").forEach(spec => {
if (!spec.isExportSpecifier()) {
throw spec.buildCodeFrameError("Unexpected export specifier type");
}
assertExportSpecifier(spec);
const importName = getExportSpecifierName(
spec.get("local"),
stringSpecifiers,
@ -415,8 +427,9 @@ function getLocalExportMetadata(
child.node.source &&
child.get("source").isStringLiteral()
) {
child.node.specifiers.forEach(specifier => {
bindingKindLookup.set(specifier.local.name, "block");
child.get("specifiers").forEach(spec => {
assertExportSpecifier(spec);
bindingKindLookup.set(spec.get("local").node.name, "block");
});
return;
}

2
packages/babel-plugin-transform-modules-commonjs/test/fixtures/noInterop-loose/export-namespace-without-plugin/input.mjs vendored Normal file
View File

@ -0,0 +1,2 @@
export * as ns from "./foo";

3
packages/babel-plugin-transform-modules-commonjs/test/fixtures/noInterop-loose/export-namespace-without-plugin/options.json vendored Normal file
View File

@ -0,0 +1,3 @@
{
"throws": "Export namespace should be first transformed by `@babel/plugin-proposal-export-namespace-from`."
}

5
packages/babel-plugin-transform-modules-commonjs/test/fixtures/noInterop-loose/options.json vendored Normal file
View File

@ -0,0 +1,5 @@
{
"plugins": [
["transform-modules-commonjs", { "noInterop": true, "loose": true }]
]
}