cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

deprecate returning source strings from visitor methods

Browse Source
This commit is contained in:
Sebastian McKenzie 2015-06-25 03:50:10 +01:00
parent 6f862a4c45
commit a35c863341
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/babel/traversal/path/replacement.js
View File

@ -112,6 +112,13 @@ export function replaceWith(replacement, whateverAllowed) {
if (typeof replacement === "string") { if (typeof replacement === "string") {
if (whateverAllowed) { if (whateverAllowed) {
this.hub.file.log.deprecate("Returning a string from a visitor method will be removed in the future. String " +
"building is NOT a substitute for AST generation. String building leads to " +
"terrible performance due to the additional parsing overhead and will lead to " +
"extremely brittle transformers. For those extreme cases where you're dealing " +
"with strings from a foreign source you may continue to use " +
"`path.replaceWithSourceString(code)`. Just please don't abuse this. Bad plugins " +
"hurt the ecosystem.");
return this.replaceWithSourceString(replacement); return this.replaceWithSourceString(replacement);
} else { } else {
throw new Error("Don't use `path.replaceWith()` with a string, use `path.replaceWithSourceString()`"); throw new Error("Don't use `path.replaceWith()` with a string, use `path.replaceWithSourceString()`");