cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Disallow arguments in class properties

Browse Source
This commit is contained in:
Nicolò Ribaudo 2018-04-12 15:06:48 +02:00
parent f797454a18
commit a62cfe9045
13 changed files with 488 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/babel-core/test/fixtures/transformation/misc/class-property-initializer-blocks-shadow/input.js vendored
View File

@ -1,10 +1,6 @@
class A {
prop1 = () => this;
static prop2 = () => this;
prop3 = () => arguments;
static prop4 = () => arguments;
prop5 = this;
static prop6 = this;
prop7 = arguments;
static prop8 = arguments;
}

4
packages/babel-core/test/fixtures/transformation/misc/class-property-initializer-blocks-shadow/output.js vendored
View File

@ -1,10 +1,6 @@
class A {
prop1 = () => this;
static prop2 = () => this;
prop3 = () => arguments;
static prop4 = () => arguments;
prop5 = this;
static prop6 = this;
prop7 = arguments;
static prop8 = arguments;
}

7
packages/babylon/src/parser/expression.js
View File

@ -1861,6 +1861,13 @@ export default class ExpressionParser extends LValParser {
);
}
if (this.state.inClassProperty && word === "arguments") {
this.raise(
startLoc,
"'arguments' is not allowed in class field initializer",
);
}
if (this.isReservedWord(word) || (checkKeywords && this.isKeyword(word))) {
this.raise(startLoc, word + " is a reserved word");
}

5
packages/babylon/test/fixtures/experimental/class-properties/arguments-in-arrow-function/input.js vendored Normal file
View File

@ -0,0 +1,5 @@
function fn() {
class A {
foo = () => arguments;
}
}

4
packages/babylon/test/fixtures/experimental/class-properties/arguments-in-arrow-function/options.json vendored Normal file
View File

@ -0,0 +1,4 @@
{
"plugins": ["classProperties"],
"throws": "'arguments' is not allowed in class field initializer (3:16)"
}

5
packages/babylon/test/fixtures/experimental/class-properties/arguments-in-function/input.js vendored Normal file
View File

@ -0,0 +1,5 @@
function fn() {
class A {
foo = function f() { arguments };
}
}

3
packages/babylon/test/fixtures/experimental/class-properties/arguments-in-function/options.json vendored Normal file
View File

@ -0,0 +1,3 @@
{
"plugins": ["classProperties"]
}

256
packages/babylon/test/fixtures/experimental/class-properties/arguments-in-function/output.json vendored Normal file
View File

@ -0,0 +1,256 @@
{
"type": "File",
"start": 0,
"end": 71,
"loc": {
"start": {
"line": 1,
"column": 0
},
"end": {
"line": 5,
"column": 1
}
},
"program": {
"type": "Program",
"start": 0,
"end": 71,
"loc": {
"start": {
"line": 1,
"column": 0
},
"end": {
"line": 5,
"column": 1
}
},
"sourceType": "script",
"body": [
{
"type": "FunctionDeclaration",
"start": 0,
"end": 71,
"loc": {
"start": {
"line": 1,
"column": 0
},
"end": {
"line": 5,
"column": 1
}
},
"id": {
"type": "Identifier",
"start": 9,
"end": 11,
"loc": {
"start": {
"line": 1,
"column": 9
},
"end": {
"line": 1,
"column": 11
},
"identifierName": "fn"
},
"name": "fn"
},
"generator": false,
"async": false,
"params": [],
"body": {
"type": "BlockStatement",
"start": 14,
"end": 71,
"loc": {
"start": {
"line": 1,
"column": 14
},
"end": {
"line": 5,
"column": 1
}
},
"body": [
{
"type": "ClassDeclaration",
"start": 18,
"end": 69,
"loc": {
"start": {
"line": 2,
"column": 2
},
"end": {
"line": 4,
"column": 3
}
},
"id": {
"type": "Identifier",
"start": 24,
"end": 25,
"loc": {
"start": {
"line": 2,
"column": 8
},
"end": {
"line": 2,
"column": 9
},
"identifierName": "A"
},
"name": "A"
},
"superClass": null,
"body": {
"type": "ClassBody",
"start": 26,
"end": 69,
"loc": {
"start": {
"line": 2,
"column": 10
},
"end": {
"line": 4,
"column": 3
}
},
"body": [
{
"type": "ClassProperty",
"start": 32,
"end": 65,
"loc": {
"start": {
"line": 3,
"column": 4
},
"end": {
"line": 3,
"column": 37
}
},
"static": false,
"key": {
"type": "Identifier",
"start": 32,
"end": 35,
"loc": {
"start": {
"line": 3,
"column": 4
},
"end": {
"line": 3,
"column": 7
},
"identifierName": "foo"
},
"name": "foo"
},
"computed": false,
"value": {
"type": "FunctionExpression",
"start": 38,
"end": 64,
"loc": {
"start": {
"line": 3,
"column": 10
},
"end": {
"line": 3,
"column": 36
}
},
"id": {
"type": "Identifier",
"start": 47,
"end": 48,
"loc": {
"start": {
"line": 3,
"column": 19
},
"end": {
"line": 3,
"column": 20
},
"identifierName": "f"
},
"name": "f"
},
"generator": false,
"async": false,
"params": [],
"body": {
"type": "BlockStatement",
"start": 51,
"end": 64,
"loc": {
"start": {
"line": 3,
"column": 23
},
"end": {
"line": 3,
"column": 36
}
},
"body": [
{
"type": "ExpressionStatement",
"start": 53,
"end": 62,
"loc": {
"start": {
"line": 3,
"column": 25
},
"end": {
"line": 3,
"column": 34
}
},
"expression": {
"type": "Identifier",
"start": 53,
"end": 62,
"loc": {
"start": {
"line": 3,
"column": 25
},
"end": {
"line": 3,
"column": 34
},
"identifierName": "arguments"
},
"name": "arguments"
}
}
],
"directives": []
}
}
}
]
}
}
],
"directives": []
}
}
],
"directives": []
}
}

5
packages/babylon/test/fixtures/experimental/class-properties/arguments-in-key/input.js vendored Normal file
View File

@ -0,0 +1,5 @@
function fn() {
class A {
[arguments] = 2;
}
}

3
packages/babylon/test/fixtures/experimental/class-properties/arguments-in-key/options.json vendored Normal file
View File

@ -0,0 +1,3 @@
{
"plugins": ["classProperties"]
}

191
packages/babylon/test/fixtures/experimental/class-properties/arguments-in-key/output.json vendored Normal file
View File

@ -0,0 +1,191 @@
{
"type": "File",
"start": 0,
"end": 54,
"loc": {
"start": {
"line": 1,
"column": 0
},
"end": {
"line": 5,
"column": 1
}
},
"program": {
"type": "Program",
"start": 0,
"end": 54,
"loc": {
"start": {
"line": 1,
"column": 0
},
"end": {
"line": 5,
"column": 1
}
},
"sourceType": "script",
"body": [
{
"type": "FunctionDeclaration",
"start": 0,
"end": 54,
"loc": {
"start": {
"line": 1,
"column": 0
},
"end": {
"line": 5,
"column": 1
}
},
"id": {
"type": "Identifier",
"start": 9,
"end": 11,
"loc": {
"start": {
"line": 1,
"column": 9
},
"end": {
"line": 1,
"column": 11
},
"identifierName": "fn"
},
"name": "fn"
},
"generator": false,
"async": false,
"params": [],
"body": {
"type": "BlockStatement",
"start": 14,
"end": 54,
"loc": {
"start": {
"line": 1,
"column": 14
},
"end": {
"line": 5,
"column": 1
}
},
"body": [
{
"type": "ClassDeclaration",
"start": 18,
"end": 52,
"loc": {
"start": {
"line": 2,
"column": 2
},
"end": {
"line": 4,
"column": 3
}
},
"id": {
"type": "Identifier",
"start": 24,
"end": 25,
"loc": {
"start": {
"line": 2,
"column": 8
},
"end": {
"line": 2,
"column": 9
},
"identifierName": "A"
},
"name": "A"
},
"superClass": null,
"body": {
"type": "ClassBody",
"start": 26,
"end": 52,
"loc": {
"start": {
"line": 2,
"column": 10
},
"end": {
"line": 4,
"column": 3
}
},
"body": [
{
"type": "ClassProperty",
"start": 32,
"end": 48,
"loc": {
"start": {
"line": 3,
"column": 4
},
"end": {
"line": 3,
"column": 20
}
},
"static": false,
"computed": true,
"key": {
"type": "Identifier",
"start": 33,
"end": 42,
"loc": {
"start": {
"line": 3,
"column": 5
},
"end": {
"line": 3,
"column": 14
},
"identifierName": "arguments"
},
"name": "arguments"
},
"value": {
"type": "NumericLiteral",
"start": 46,
"end": 47,
"loc": {
"start": {
"line": 3,
"column": 18
},
"end": {
"line": 3,
"column": 19
}
},
"extra": {
"rawValue": 2,
"raw": "2"
},
"value": 2
}
}
]
}
}
],
"directives": []
}
}
],
"directives": []
}
}

5
packages/babylon/test/fixtures/experimental/class-properties/arguments/input.js vendored Normal file
View File

@ -0,0 +1,5 @@
function fn() {
class A {
foo = arguments;
}
}

4
packages/babylon/test/fixtures/experimental/class-properties/arguments/options.json vendored Normal file
View File

@ -0,0 +1,4 @@
{
"plugins": ["classProperties"],
"throws": "'arguments' is not allowed in class field initializer (3:10)"
}