cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Ensure array is always copied during destructure

Browse Source
This commit is contained in:
Brian Ng 2017-01-11 09:23:21 -06:00
parent 39d18679e1
commit a749907bc2
No known key found for this signature in database
GPG Key ID: 3F2380E1E1508CA9
2 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
packages/babel-plugin-transform-es2015-destructuring/src/index.js
View File

@ -294,10 +294,7 @@ export default function ({ types: t }) {
if (t.isRestElement(elem)) { if (t.isRestElement(elem)) {
elemRef = this.toArray(arrayRef); elemRef = this.toArray(arrayRef);
if (i > 0) {
elemRef = t.callExpression(t.memberExpression(elemRef, t.identifier("slice")), [t.numericLiteral(i)]); elemRef = t.callExpression(t.memberExpression(elemRef, t.identifier("slice")), [t.numericLiteral(i)]);
}
// set the element to the rest element argument since we've dealt with it // set the element to the rest element argument since we've dealt with it
// being a rest already // being a rest already

9
packages/babel-plugin-transform-es2015-destructuring/test/fixtures/destructuring/issue-5090/exec.js vendored Normal file
View File

@ -0,0 +1,9 @@
const assign = ([...arr], index, value) => {
arr[index] = value;
return arr;
}
const arr = [1, 2, 3];
assign(arr, 1, 42);
assert.deepEqual(arr, [1, 2, 3]);