logical-assignment: Do not assign names to anonymous functions (#11370)

packages/babel-plugin-proposal-logical-assignment-operators/src/index.js

@@ -39,11 +39,16 @@ export default declare(api => {
           }
         }
 
+        const isRHSAnonymousFunction = t.isFunction(right, { id: null });
+        const rightExpression = isRHSAnonymousFunction
+          ? t.sequenceExpression([t.numericLiteral(0), right])
+          : right;
+
         path.replaceWith(
           t.logicalExpression(
             operator.slice(0, -1),
             lhs,
-            t.assignmentExpression("=", left, right),
+            t.assignmentExpression("=", left, rightExpression),
           ),
         );
       },

packages/babel-plugin-proposal-logical-assignment-operators/test/fixtures/logical-assignment/anonymous-functions-exec/exec.js

@@ -0,0 +1,9 @@
+var a, b = true, c;
+
+a ||= function () {};
+b &&= function () {};
+c ??= function () {};
+
+expect(a.name).toBe("");
+expect(b.name).toBe("");
+expect(c.name).toBe("");

packages/babel-plugin-proposal-logical-assignment-operators/test/fixtures/logical-assignment/anonymous-functions-exec/options.json

@@ -0,0 +1,6 @@
+{
+  "plugins": [
+    "proposal-logical-assignment-operators",
+    "proposal-nullish-coalescing-operator"
+  ]
+}

packages/babel-plugin-proposal-logical-assignment-operators/test/fixtures/logical-assignment/anonymous-functions-transform/input.js

@@ -0,0 +1,4 @@
+var a;
+a ||= function () {};
+a &&= function () {};
+a ??= function () {};

packages/babel-plugin-proposal-logical-assignment-operators/test/fixtures/logical-assignment/anonymous-functions-transform/options.json

@@ -0,0 +1,3 @@
+{
+  "plugins": ["proposal-logical-assignment-operators"]
+}

packages/babel-plugin-proposal-logical-assignment-operators/test/fixtures/logical-assignment/anonymous-functions-transform/output.js

@@ -0,0 +1,4 @@
+var a;
+a || (a = (0, function () {}));
+a && (a = (0, function () {}));
+a ?? (a = (0, function () {}));

packages/babel-plugin-proposal-logical-assignment-operators/test/fixtures/logical-assignment/arrow-functions-exec/exec.js

@@ -0,0 +1,9 @@
+var a, b = true, c;
+
+a ||= () => {};
+b &&= () => {};
+c ??= () => {};
+
+expect(a.name).toBe("");
+expect(b.name).toBe("");
+expect(c.name).toBe("");

packages/babel-plugin-proposal-logical-assignment-operators/test/fixtures/logical-assignment/arrow-functions-exec/options.json

@@ -0,0 +1,6 @@
+{
+  "plugins": [
+    "proposal-logical-assignment-operators",
+    "proposal-nullish-coalescing-operator"
+  ]
+}

packages/babel-plugin-proposal-logical-assignment-operators/test/fixtures/logical-assignment/arrow-functions-transform/input.js

@@ -0,0 +1,4 @@
+var a;
+a ||= () => {};
+a &&= () => {};
+a ??= () => {};

packages/babel-plugin-proposal-logical-assignment-operators/test/fixtures/logical-assignment/arrow-functions-transform/options.json

@@ -0,0 +1,3 @@
+{
+  "plugins": ["proposal-logical-assignment-operators"]
+}

packages/babel-plugin-proposal-logical-assignment-operators/test/fixtures/logical-assignment/arrow-functions-transform/output.js

@@ -0,0 +1,4 @@
+var a;
+a || (a = (0, () => {}));
+a && (a = (0, () => {}));
+a ?? (a = (0, () => {}));

packages/babel-plugin-proposal-logical-assignment-operators/test/fixtures/logical-assignment/named-functions-exec/exec.js

@@ -0,0 +1,9 @@
+var a, b = true, c;
+
+a ||= function d() {};
+b &&= function e() {};
+c ??= function f() {};
+
+expect(a.name).toBe("d");
+expect(b.name).toBe("e");
+expect(c.name).toBe("f");

packages/babel-plugin-proposal-logical-assignment-operators/test/fixtures/logical-assignment/named-functions-exec/options.json

@@ -0,0 +1,6 @@
+{
+  "plugins": [
+    "proposal-logical-assignment-operators",
+    "proposal-nullish-coalescing-operator"
+  ]
+}

packages/babel-plugin-proposal-logical-assignment-operators/test/fixtures/logical-assignment/named-functions-transform/input.js

@@ -0,0 +1,4 @@
+var a;
+a ||= function d() {};
+a &&= function e() {};
+a ??= function f() {};

packages/babel-plugin-proposal-logical-assignment-operators/test/fixtures/logical-assignment/named-functions-transform/options.json

@@ -0,0 +1,3 @@
+{
+  "plugins": ["proposal-logical-assignment-operators"]
+}

packages/babel-plugin-proposal-logical-assignment-operators/test/fixtures/logical-assignment/named-functions-transform/output.js

@@ -0,0 +1,4 @@
+var a;
+a || (a = function d() {});
+a && (a = function e() {});
+a ?? (a = function f() {});