cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

fix: clone comments in cloneNode (#13178)

Browse Source
This commit is contained in:
Jason 2021-04-20 22:34:12 +08:00 committed by GitHub
parent 86d9cf5020
commit ab06ccad49
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
packages/babel-types/src/clone/cloneNode.ts
View File

@ -102,25 +102,18 @@ export default function cloneNode<T extends t.Node>(
return newNode;
}
function cloneCommentsWithoutLoc<T extends t.Comment>(
comments: ReadonlyArray<T>,
): T[] {
return comments.map(
({ type, value }) =>
({
type,
value,
loc: null,
} as T),
);
}
function maybeCloneComments<T extends t.Comment>(
comments: ReadonlyArray<T> | null,
deep: boolean,
withoutLoc: boolean,
): ReadonlyArray<T> | null {
return deep && withoutLoc && comments
? cloneCommentsWithoutLoc(comments)
: comments;
if (!comments || !deep) {
return comments;
}
return comments.map(({ type, value, loc }) => {
if (withoutLoc) {
return { type, value, loc: null } as T;
}
return { type, value, loc } as T;
});
}

3
packages/babel-types/test/cloning.js
View File

@ -120,6 +120,9 @@ describe("cloneNode", function () {
node.declarations[0].id.loc = {};
const cloned = t.cloneNode(node, /* deep */ true, /* withoutLoc */ false);
expect(cloned.declarations[0].id.leadingComments[0]).not.toBe(
node.declarations[0].id.leadingComments[0],
);
expect(cloned.declarations[0].id.leadingComments[0].loc).toBe(
node.declarations[0].id.leadingComments[0].loc,
);