From adec9f4b8ee4cac6ba682330b83540a0e988e73b Mon Sep 17 00:00:00 2001 From: Ingvar Stepanyan Date: Wed, 17 Dec 2014 20:37:00 +0200 Subject: [PATCH] Provide better error on member expression in binding's left side. --- acorn.js | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/acorn.js b/acorn.js index 291f7b414c..3f15583c13 100644 --- a/acorn.js +++ b/acorn.js @@ -1489,14 +1489,12 @@ switch (expr.type) { case "Identifier": if (strict && (isStrictBadIdWord(expr.name) || isStrictReservedWord(expr.name))) - raise(expr.start, isBinding - ? "Binding " + expr.name + " in strict mode" - : "Assigning to " + expr.name + " in strict mode" - ); + raise(expr.start, (isBinding ? "Binding " : "Assigning to ") + expr.name + " in strict mode"); break; case "MemberExpression": - if (!isBinding) break; + if (isBinding) raise(expr.start, "Binding to member expression"); + break; case "ObjectPattern": for (var i = 0; i < expr.properties.length; i++)