recurse over and duplicate array in toArray in order to handle sparse arrays - fixes #754

lib/6to5/transformation/templates/to-array.js

@@ -1,3 +1,9 @@
 (function (arr) {
-  return Array.isArray(arr) ? arr : Array.from(arr);
+  if (Array.isArray(arr)) {
+    var arr2 = [];
+    for (var i = 0; i < arr.length; i++) arr2.push(arr[i]);
+      return arr2;
+  } else {
+    return Array.from(arr);
+  }
 });

test/fixtures/transformation/es6-destructuring/spread/expected.js

@@ -1,6 +1,6 @@
 "use strict";
 
-var _toArray = function (arr) { return Array.isArray(arr) ? arr : Array.from(arr); };
+var _toArray = function (arr) { if (Array.isArray(arr)) { var arr2 = []; for (var i = 0; i < arr.length; i++) arr2.push(arr[i]); return arr2; } else { return Array.from(arr); } };
 
 var isSorted = function (_ref) {
   var _ref2 = _toArray(_ref);
@@ -12,4 +12,4 @@ var isSorted = function (_ref) {
   if (!zs.length) return true;
   if (y > x) return isSorted(zs);
   return false;
-};
+};

test/fixtures/transformation/es6-spread/array-literal-first/expected.js

@@ -1,5 +1,5 @@
 "use strict";
 
-var _toArray = function (arr) { return Array.isArray(arr) ? arr : Array.from(arr); };
+var _toArray = function (arr) { if (Array.isArray(arr)) { var arr2 = []; for (var i = 0; i < arr.length; i++) arr2.push(arr[i]); return arr2; } else { return Array.from(arr); } };
 
-var lyrics = [].concat(_toArray(parts), ["head", "and", "toes"]);
+var lyrics = [].concat(_toArray(parts), ["head", "and", "toes"]);

test/fixtures/transformation/es6-spread/array-literal-middle/expected.js

@@ -1,5 +1,5 @@
 "use strict";
 
-var _toArray = function (arr) { return Array.isArray(arr) ? arr : Array.from(arr); };
+var _toArray = function (arr) { if (Array.isArray(arr)) { var arr2 = []; for (var i = 0; i < arr.length; i++) arr2.push(arr[i]); return arr2; } else { return Array.from(arr); } };
 
-var a = [b].concat(_toArray(c), [d]);
+var a = [b].concat(_toArray(c), [d]);

test/fixtures/transformation/es6-spread/array-literal-multiple/expected.js

@@ -1,5 +1,5 @@
 "use strict";
 
-var _toArray = function (arr) { return Array.isArray(arr) ? arr : Array.from(arr); };
+var _toArray = function (arr) { if (Array.isArray(arr)) { var arr2 = []; for (var i = 0; i < arr.length; i++) arr2.push(arr[i]); return arr2; } else { return Array.from(arr); } };
 
-var a = [b].concat(_toArray(c), [d, e], _toArray(f));
+var a = [b].concat(_toArray(c), [d, e], _toArray(f));

test/fixtures/transformation/es6-spread/array-literals/expected.js

@@ -1,5 +1,5 @@
 "use strict";
 
-var _toArray = function (arr) { return Array.isArray(arr) ? arr : Array.from(arr); };
+var _toArray = function (arr) { if (Array.isArray(arr)) { var arr2 = []; for (var i = 0; i < arr.length; i++) arr2.push(arr[i]); return arr2; } else { return Array.from(arr); } };
 
-var lyrics = ["head", "and", "toes"].concat(_toArray(parts));
+var lyrics = ["head", "and", "toes"].concat(_toArray(parts));

test/fixtures/transformation/es6-spread/contexted-computed-method-call-multiple-args/expected.js

@@ -1,6 +1,6 @@
 "use strict";
 
 var _obj;
-var _toArray = function (arr) { return Array.isArray(arr) ? arr : Array.from(arr); };
+var _toArray = function (arr) { if (Array.isArray(arr)) { var arr2 = []; for (var i = 0; i < arr.length; i++) arr2.push(arr[i]); return arr2; } else { return Array.from(arr); } };
 
-(_obj = obj)[method].apply(_obj, [foo, bar].concat(_toArray(args)));
+(_obj = obj)[method].apply(_obj, [foo, bar].concat(_toArray(args)));

test/fixtures/transformation/es6-spread/contexted-computed-method-call-single-arg/expected.js

@@ -1,6 +1,6 @@
 "use strict";
 
 var _obj;
-var _toArray = function (arr) { return Array.isArray(arr) ? arr : Array.from(arr); };
+var _toArray = function (arr) { if (Array.isArray(arr)) { var arr2 = []; for (var i = 0; i < arr.length; i++) arr2.push(arr[i]); return arr2; } else { return Array.from(arr); } };
 
-(_obj = obj)[method].apply(_obj, _toArray(args));
+(_obj = obj)[method].apply(_obj, _toArray(args));

test/fixtures/transformation/es6-spread/contexted-method-call-multiple-args/expected.js

@@ -1,7 +1,7 @@
 "use strict";
 
 var _foob, _foob$test;
-var _toArray = function (arr) { return Array.isArray(arr) ? arr : Array.from(arr); };
+var _toArray = function (arr) { if (Array.isArray(arr)) { var arr2 = []; for (var i = 0; i < arr.length; i++) arr2.push(arr[i]); return arr2; } else { return Array.from(arr); } };
 
 (_foob = foob).add.apply(_foob, [foo, bar].concat(_toArray(numbers)));
-(_foob$test = foob.test).add.apply(_foob$test, [foo, bar].concat(_toArray(numbers)));
+(_foob$test = foob.test).add.apply(_foob$test, [foo, bar].concat(_toArray(numbers)));

test/fixtures/transformation/es6-spread/contexted-method-call-single-arg/expected.js

@@ -1,7 +1,7 @@
 "use strict";
 
 var _foob, _foob$test;
-var _toArray = function (arr) { return Array.isArray(arr) ? arr : Array.from(arr); };
+var _toArray = function (arr) { if (Array.isArray(arr)) { var arr2 = []; for (var i = 0; i < arr.length; i++) arr2.push(arr[i]); return arr2; } else { return Array.from(arr); } };
 
 (_foob = foob).add.apply(_foob, _toArray(numbers));
-(_foob$test = foob.test).add.apply(_foob$test, _toArray(numbers));
+(_foob$test = foob.test).add.apply(_foob$test, _toArray(numbers));

test/fixtures/transformation/es6-spread/method-call-first/expected.js

@@ -1,5 +1,5 @@
 "use strict";
 
-var _toArray = function (arr) { return Array.isArray(arr) ? arr : Array.from(arr); };
+var _toArray = function (arr) { if (Array.isArray(arr)) { var arr2 = []; for (var i = 0; i < arr.length; i++) arr2.push(arr[i]); return arr2; } else { return Array.from(arr); } };
 
-add.apply(undefined, _toArray(numbers).concat([foo, bar]));
+add.apply(undefined, _toArray(numbers).concat([foo, bar]));

test/fixtures/transformation/es6-spread/method-call-middle/expected.js

@@ -1,5 +1,5 @@
 "use strict";
 
-var _toArray = function (arr) { return Array.isArray(arr) ? arr : Array.from(arr); };
+var _toArray = function (arr) { if (Array.isArray(arr)) { var arr2 = []; for (var i = 0; i < arr.length; i++) arr2.push(arr[i]); return arr2; } else { return Array.from(arr); } };
 
-add.apply(undefined, [foo].concat(_toArray(numbers), [bar]));
+add.apply(undefined, [foo].concat(_toArray(numbers), [bar]));

test/fixtures/transformation/es6-spread/method-call-multiple-args/expected.js

@@ -1,5 +1,5 @@
 "use strict";
 
-var _toArray = function (arr) { return Array.isArray(arr) ? arr : Array.from(arr); };
+var _toArray = function (arr) { if (Array.isArray(arr)) { var arr2 = []; for (var i = 0; i < arr.length; i++) arr2.push(arr[i]); return arr2; } else { return Array.from(arr); } };
 
-add.apply(undefined, [foo, bar].concat(_toArray(numbers)));
+add.apply(undefined, [foo, bar].concat(_toArray(numbers)));

test/fixtures/transformation/es6-spread/method-call-multiple/expected.js

@@ -1,5 +1,5 @@
 "use strict";
 
-var _toArray = function (arr) { return Array.isArray(arr) ? arr : Array.from(arr); };
+var _toArray = function (arr) { if (Array.isArray(arr)) { var arr2 = []; for (var i = 0; i < arr.length; i++) arr2.push(arr[i]); return arr2; } else { return Array.from(arr); } };
 
-add.apply(undefined, [foo].concat(_toArray(numbers), [bar, what], _toArray(test)));
+add.apply(undefined, [foo].concat(_toArray(numbers), [bar, what], _toArray(test)));

test/fixtures/transformation/es6-spread/method-call-single-arg/expected.js

@@ -1,5 +1,5 @@
 "use strict";
 
-var _toArray = function (arr) { return Array.isArray(arr) ? arr : Array.from(arr); };
+var _toArray = function (arr) { if (Array.isArray(arr)) { var arr2 = []; for (var i = 0; i < arr.length; i++) arr2.push(arr[i]); return arr2; } else { return Array.from(arr); } };
 
-add.apply(undefined, _toArray(numbers));
+add.apply(undefined, _toArray(numbers));

test/fixtures/transformation/es6-spread/new-expression/expected.js

@@ -2,7 +2,7 @@
 
 var _applyConstructor = function (Constructor, args) { var instance = Object.create(Constructor.prototype); var result = Constructor.apply(instance, args); return result != null && (typeof result == "object" || typeof result == "function") ? result : instance; };
 
-var _toArray = function (arr) { return Array.isArray(arr) ? arr : Array.from(arr); };
+var _toArray = function (arr) { if (Array.isArray(arr)) { var arr2 = []; for (var i = 0; i < arr.length; i++) arr2.push(arr[i]); return arr2; } else { return Array.from(arr); } };
 
 _applyConstructor(Numbers, _toArray(nums));
-_applyConstructor(Numbers, [1].concat(_toArray(nums)));
+_applyConstructor(Numbers, [1].concat(_toArray(nums)));

test/fixtures/transformation/es6-spread/single/expected.js

@@ -1,5 +1,5 @@
 "use strict";
 
-var _toArray = function (arr) { return Array.isArray(arr) ? arr : Array.from(arr); };
+var _toArray = function (arr) { if (Array.isArray(arr)) { var arr2 = []; for (var i = 0; i < arr.length; i++) arr2.push(arr[i]); return arr2; } else { return Array.from(arr); } };
 
-[].concat(_toArray(foo));
+[].concat(_toArray(foo));