cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

fix generate-helpers failing in URL-encoded path (#13404)

Browse Source 
HELPERS_FOLDER.pathname may be URL-encoded, if the working tree's
absolute path contains spaces, some reserved characters, or anything
beyond ASCII.

readFile accepts a plain String or URL for the path, but does not
automatically decode URL-encoded Strings.
This commit is contained in:
lightmare 2021-05-31 21:45:54 +02:00 committed by GitHub
parent 08772e28f2
commit b397aca024
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/babel-helpers/scripts/generate-helpers.js
View File

@ -1,6 +1,6 @@
import fs from "fs"; import fs from "fs";
import { join } from "path"; import { join } from "path";
import { URL } from "url"; import { URL, fileURLToPath } from "url";
const HELPERS_FOLDER = new URL("../src/helpers", import.meta.url); const HELPERS_FOLDER = new URL("../src/helpers", import.meta.url);
const IGNORED_FILES = new Set(["package.json"]); const IGNORED_FILES = new Set(["package.json"]);
@ -23,7 +23,7 @@ import template from "@babel/template";
const varName = isValidId ? helperName : `_${helperName}`; const varName = isValidId ? helperName : `_${helperName}`;
const fileContents = await fs.promises.readFile( const fileContents = await fs.promises.readFile(
join(HELPERS_FOLDER.pathname, file), join(fileURLToPath(HELPERS_FOLDER), file),
"utf8" "utf8"
); );
const { minVersion } = fileContents.match( const { minVersion } = fileContents.match(