cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Automatically generate missing expected.js fixtures (#4735)

Browse Source 
This is much like Babylon's existing behavior around `expected.json`. The equivalent of babel/babylon#188 is already applied here, to guard against silent failure (and a potential false positive) if a test is accidentally committed without its expected.js.
This commit is contained in:
Moti Zilberman 2016-10-17 17:39:32 +03:00 committed by Daniel Tschinder
parent 478bba0ade
commit b8eeddf960
2 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
CONTRIBUTING.md
View File

@ -145,9 +145,9 @@ If you need to check for an error that is thrown you can add to the `options.jso
} }
``` ```
##### `babylon` ##### Bootstrapping expected output
For `babylon` specifically, you can easily generate an `expected.json` automatically by just providing the `actual.js` and running `make test-only` as you usually would. For both `babel-plugin-x` and `babylon`, you can easily generate an `expected.js`/`expected.json` automatically by just providing `actual.js` and running the tests as you usually would.
``` ```
// Example // Example

14
packages/babel-helper-transform-fixture-test-runner/src/index.js
View File

@ -8,6 +8,8 @@ import assert from "assert";
import chai from "chai"; import chai from "chai";
import _ from "lodash"; import _ from "lodash";
import "babel-polyfill"; import "babel-polyfill";
import fs from "fs";
import path from "path";
let babelHelpers = eval(buildExternalHelpers(null, "var")); let babelHelpers = eval(buildExternalHelpers(null, "var"));
@ -63,14 +65,12 @@ function run(task) {
let actualCode = actual.code; let actualCode = actual.code;
let expectCode = expect.code; let expectCode = expect.code;
if (!execCode || actualCode) { if (!execCode || actualCode) {
result = babel.transform(actualCode, getOpts(actual)); result = babel.transform(actualCode, getOpts(actual));
actualCode = result.code.trim(); if (!expect.code && result.code && !opts.throws && fs.statSync(path.dirname(expect.loc)).isDirectory() && !process.env.CI) {
fs.writeFileSync(expect.loc, result.code);
try { } else {
actualCode = result.code.trim();
chai.expect(actualCode).to.be.equal(expectCode, actual.loc + " !== " + expect.loc); chai.expect(actualCode).to.be.equal(expectCode, actual.loc + " !== " + expect.loc);
} catch (err) {
//require("fs").writeFileSync(expect.loc, actualCode);
throw err;
} }
} }