Define default value for vars shadowing params (#11307)

* Define default value for vars shadowing params

* Remove from package.json

* Only convert traverse the params if needed

This prevents this plugin from running after the destructuring
transform, which causes #11256

* Review

* Review

* Update packages/babel-plugin-transform-parameters/src/params.js [skip ci]

Co-Authored-By: Brian Ng <bng412@gmail.com>

Co-authored-by: Brian Ng <bng412@gmail.com>
This commit is contained in:
Nicolò Ribaudo
2020-03-22 10:45:10 +01:00
committed by GitHub
parent b0315b81c7
commit ceb54dd756
19 changed files with 129 additions and 66 deletions

View File

@@ -1,6 +1,6 @@
function foo() {
var a = arguments.length > 0 && arguments[0] !== undefined ? arguments[0] : 2;
return function () {
return function (a) {
function a() {}
}();
}(a);
}

View File

@@ -10,11 +10,13 @@ var Test = /*#__PURE__*/function () {
babelHelpers.createClass(Test, [{
key: "invite",
value: function invite() {
var _this = this;
var p = arguments.length > 0 && arguments[0] !== undefined ? arguments[0] : a;
return function () {
var a;
this;
}.apply(this);
_this;
}();
}
}]);
return Test;

View File

@@ -1,5 +1,5 @@
function foo(a = 2) {
for (var a, i = 0; i < 1; i++);
expect(a).toBe(undefined);
expect(a).toBe(2);
}
foo();

View File

@@ -1,8 +1,8 @@
function f() {
var a = arguments.length > 0 && arguments[0] !== undefined ? arguments[0] : 2;
var b = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : 3;
return function () {
return function (b) {
var b = 4;
return a + b;
}();
}(b);
}

View File

@@ -1,11 +1,11 @@
function f() {
var a = arguments.length > 0 && arguments[0] !== undefined ? arguments[0] : 2;
var b = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : 3;
return function () {
return function (a) {
var _a = {
a: 4
},
a = _a.a;
return a + b;
}();
}(a);
}

View File

@@ -1,9 +1,9 @@
function foo(_ref) {
var a = _ref.a,
b = _ref.b;
return function () {
return function (a) {
var a = 3;
var c = 2;
var d = a + b + c;
}();
}(a);
}

View File

@@ -3,9 +3,9 @@ function foo(_ref) {
a = _ref2[0],
b = _ref2[1];
return function () {
return function (a) {
var a = 3;
var c = 2;
var d = a + b + c;
}();
}(a);
}

View File

@@ -1,6 +1,6 @@
function foo() {
var a = arguments.length > 0 && arguments[0] !== undefined ? arguments[0] : 2;
return function () {
return function (a) {
var a = 1;
}();
}(a);
}

View File

@@ -1,11 +1,11 @@
function f() {
var a = arguments.length > 0 && arguments[0] !== undefined ? arguments[0] : 2;
var b = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : 3;
return function () {
return function (a) {
var _a = {
a: 4
},
a = _a.a;
return a + b;
}();
}(a);
}