cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

clean up visitor verification

Browse Source
This commit is contained in:
Sebastian McKenzie 2015-11-08 06:03:11 -08:00
parent e40c93791c
commit d1c4945a13
1 changed files with 16 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
packages/babel-traverse/src/visitors.js
View File

@ -13,13 +13,13 @@ export function explode(visitor) {
for (let nodeType in visitor) { for (let nodeType in visitor) {
if (shouldIgnoreKey(nodeType)) continue; if (shouldIgnoreKey(nodeType)) continue;
let parts = nodeType.split("|"); let parts: Array<string> = nodeType.split("|");
if (parts.length === 1) continue; if (parts.length === 1) continue;
let fns = visitor[nodeType]; let fns = visitor[nodeType];
delete visitor[nodeType]; delete visitor[nodeType];
for (let part of (parts: Array)) { for (let part of parts) {
visitor[part] = fns; visitor[part] = fns;
} }
} }
@ -113,6 +113,10 @@ export function verify(visitor) {
} }
for (let nodeType in visitor) { for (let nodeType in visitor) {
if (nodeType === "enter" || nodeType === "exit") {
validateVisitorMethods(nodeType, visitor[nodeType]);
}
if (shouldIgnoreKey(nodeType)) continue; if (shouldIgnoreKey(nodeType)) continue;
if (t.TYPES.indexOf(nodeType) < 0) { if (t.TYPES.indexOf(nodeType) < 0) {
@ -124,13 +128,7 @@ export function verify(visitor) {
for (let visitorKey in visitors) { for (let visitorKey in visitors) {
if (visitorKey === "enter" || visitorKey === "exit") { if (visitorKey === "enter" || visitorKey === "exit") {
// verify that it just contains functions // verify that it just contains functions
let val = visitors[visitorKey]; validateVisitorMethods(`${nodeType}.${visitorKey}`, visitors[visitorKey]);
let fns = [].concat(val);
for (let fn of fns) {
if (typeof fn !== "function") {
throw new TypeError(`Non-function found defined in ${nodeType}.${visitorKey} with type ${typeof fn}`);
}
}
} else { } else {
throw new Error(messages.get("traverseVerifyVisitorProperty", nodeType, visitorKey)); throw new Error(messages.get("traverseVerifyVisitorProperty", nodeType, visitorKey));
} }
@ -141,6 +139,15 @@ export function verify(visitor) {
visitor._verified = true; visitor._verified = true;
} }
function validateVisitorMethods(path, val) {
let fns = [].concat(val);
for (let fn of fns) {
if (typeof fn !== "function") {
throw new TypeError(`Non-function found defined in ${path} with type ${typeof fn}`);
}
}
}
export function merge(visitors: Array, states: Array = []) { export function merge(visitors: Array, states: Array = []) {
let rootVisitor = {}; let rootVisitor = {};