cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Account for ConfigItem being generated by another copy of Babel (#11734)

Browse Source 
Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
Co-authored-by: Huáng Jùnliàng <jlhwung@gmail.com>
This commit is contained in:
Jason Miller 2020-11-10 09:02:46 -05:00 committed by GitHub
parent 4b1b961bd1
commit ddd868f838
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
packages/babel-core/src/config/item.js
View File

@ -1,5 +1,7 @@
// @flow // @flow
/*:: declare var invariant; */
import type { PluginTarget, PluginOptions } from "./validation/options"; import type { PluginTarget, PluginOptions } from "./validation/options";
import path from "path"; import path from "path";
@ -40,7 +42,8 @@ export function createConfigItem(
} }
export function getItemDescriptor(item: mixed): UnloadedDescriptor | void { export function getItemDescriptor(item: mixed): UnloadedDescriptor | void {
if (item instanceof ConfigItem) { if ((item: any)?.[CONFIG_ITEM_BRAND]) {
/*:: invariant(item instanceof ConfigItem) */
return item._descriptor; return item._descriptor;
} }
@ -49,6 +52,8 @@ export function getItemDescriptor(item: mixed): UnloadedDescriptor | void {
export type { ConfigItem }; export type { ConfigItem };
const CONFIG_ITEM_BRAND = Symbol.for("@babel/core@7 - ConfigItem");
/** /**
* A public representation of a plugin/preset that will _eventually_ be load. * A public representation of a plugin/preset that will _eventually_ be load.
* Users can use this to interact with the results of a loaded Babel * Users can use this to interact with the results of a loaded Babel
@ -64,6 +69,13 @@ class ConfigItem {
*/ */
_descriptor: UnloadedDescriptor; _descriptor: UnloadedDescriptor;
// TODO(Babel 8): Check if this symbol needs to be updated
/**
* Used to detect ConfigItem instances from other Babel instances.
*/
// $FlowIgnore
[CONFIG_ITEM_BRAND] = true;
/** /**
* The resolved value of the item itself. * The resolved value of the item itself.
*/ */
@ -105,6 +117,8 @@ class ConfigItem {
this._descriptor = descriptor; this._descriptor = descriptor;
Object.defineProperty(this, "_descriptor", { enumerable: false }); Object.defineProperty(this, "_descriptor", { enumerable: false });
Object.defineProperty(this, CONFIG_ITEM_BRAND, { enumerable: false });
this.value = this._descriptor.value; this.value = this._descriptor.value;
this.options = this._descriptor.options; this.options = this._descriptor.options;
this.dirname = this._descriptor.dirname; this.dirname = this._descriptor.dirname;