Use new Array instead of Array for V8 optimization (#6250)

* Use new Array instead of Array for V8 optimization

* fix spacing [skip ci]

* Remove extraneous use strict clauses

packages/babel-helpers/src/helpers.js

@@ -54,7 +54,7 @@ helpers.jsx = defineHelper(`
     if (childrenLength === 1) {
       props.children = children;
     } else if (childrenLength > 1) {
-      var childArray = Array(childrenLength);
+      var childArray = new Array(childrenLength);
       for (var i = 0; i < childrenLength; i++) {
         childArray[i] = arguments[i + 3];
       }
@@ -621,7 +621,7 @@ helpers.toArray = defineHelper(`
 helpers.toConsumableArray = defineHelper(`
   export default function _toConsumableArray(arr) {
     if (Array.isArray(arr)) {
-      for (var i = 0, arr2 = Array(arr.length); i < arr.length; i++) arr2[i] = arr[i];
+      for (var i = 0, arr2 = new Array(arr.length); i < arr.length; i++) arr2[i] = arr[i];
       return arr2;
     } else {
       return Array.from(arr);

packages/babel-plugin-transform-async-to-generator/test/fixtures/async-to-generator/deeply-nested-asyncs/expected.js

@@ -3,7 +3,7 @@ let s = (() => {
     var _this = this,
         _arguments = arguments;
 
-    for (var _len = arguments.length, args = Array(_len > 1 ? _len - 1 : 0), _key = 1; _key < _len; _key++) {
+    for (var _len = arguments.length, args = new Array(_len > 1 ? _len - 1 : 0), _key = 1; _key < _len; _key++) {
       args[_key - 1] = arguments[_key];
     }
 
@@ -13,7 +13,7 @@ let s = (() => {
           var _ref3 = babelHelpers.asyncToGenerator(function* (z, b) {
             yield z;
 
-            for (var _len2 = arguments.length, innerArgs = Array(_len2 > 2 ? _len2 - 2 : 0), _key2 = 2; _key2 < _len2; _key2++) {
+            for (var _len2 = arguments.length, innerArgs = new Array(_len2 > 2 ? _len2 - 2 : 0), _key2 = 2; _key2 < _len2; _key2++) {
               innerArgs[_key2 - 2] = arguments[_key2];
             }
 

packages/babel-plugin-transform-class-properties/test/fixtures/regression/6154/expected.js

@@ -29,7 +29,7 @@ var Test = function Test() {
 
       _classCallCheck(this, Other);
 
-      for (var _len = arguments.length, args = Array(_len), _key = 0; _key < _len; _key++) {
+      for (var _len = arguments.length, args = new Array(_len), _key = 0; _key < _len; _key++) {
         args[_key] = arguments[_key];
       }
 

packages/babel-plugin-transform-es2015-parameters/src/rest.js

@@ -3,7 +3,7 @@ import * as t from "babel-types";
 
 const buildRest = template(`
   for (var LEN = ARGUMENTS.length,
-           ARRAY = Array(ARRAY_LEN),
+           ARRAY = new Array(ARRAY_LEN),
            KEY = START;
        KEY < LEN;
        KEY++) {

packages/babel-plugin-transform-es2015-parameters/test/fixtures/parameters/destructuring-rest/expected.js

@@ -5,7 +5,7 @@ function t() {
       a = _arguments$.a,
       b = _arguments$.b;
 
-  for (var _len = arguments.length, args = Array(_len > 2 ? _len - 2 : 0), _key = 2; _key < _len; _key++) {
+  for (var _len = arguments.length, args = new Array(_len > 2 ? _len - 2 : 0), _key = 2; _key < _len; _key++) {
     args[_key - 2] = arguments[_key];
   }
 

packages/babel-plugin-transform-es2015-parameters/test/fixtures/parameters/regression-4333/expected.js

@@ -1,7 +1,7 @@
 var args = 'bar';
 
 function foo() {
-  for (var _len = arguments.length, args = Array(_len), _key = 0; _key < _len; _key++) {
+  for (var _len = arguments.length, args = new Array(_len), _key = 0; _key < _len; _key++) {
     args[_key] = arguments[_key];
   }
 

packages/babel-plugin-transform-es2015-parameters/test/fixtures/parameters/regression-4634/expected.js

@@ -1,5 +1,5 @@
 let oneOf = function () {
-  for (var _len = arguments.length, nodes = Array(_len), _key = 0; _key < _len; _key++) {
+  for (var _len = arguments.length, nodes = new Array(_len), _key = 0; _key < _len; _key++) {
     nodes[_key] = arguments[_key];
   }
 

packages/babel-plugin-transform-es2015-parameters/test/fixtures/parameters/rest-arguments-deoptimisation/expected.js

@@ -1,5 +1,5 @@
 function x() {
-  for (var _len = arguments.length, rest = Array(_len), _key = 0; _key < _len; _key++) {
+  for (var _len = arguments.length, rest = new Array(_len), _key = 0; _key < _len; _key++) {
     rest[_key] = arguments[_key];
   }
 

packages/babel-plugin-transform-es2015-parameters/test/fixtures/parameters/rest-arrow-functions/expected.js

@@ -24,7 +24,7 @@ var somefun = function () {
 };
 
 function demo1() {
-  for (var _len = arguments.length, args = Array(_len), _key = 0; _key < _len; _key++) {
+  for (var _len = arguments.length, args = new Array(_len), _key = 0; _key < _len; _key++) {
     args[_key] = arguments[_key];
   }
 
@@ -36,7 +36,7 @@ function demo1() {
 var x = function () {
   if (noNeedToWork) return 0;
 
-  for (var _len2 = arguments.length, rest = Array(_len2), _key2 = 0; _key2 < _len2; _key2++) {
+  for (var _len2 = arguments.length, rest = new Array(_len2), _key2 = 0; _key2 < _len2; _key2++) {
     rest[_key2] = arguments[_key2];
   }
 
@@ -46,7 +46,7 @@ var x = function () {
 var innerclassproperties = function () {
   var _class, _temp;
 
-  for (var _len3 = arguments.length, args = Array(_len3), _key3 = 0; _key3 < _len3; _key3++) {
+  for (var _len3 = arguments.length, args = new Array(_len3), _key3 = 0; _key3 < _len3; _key3++) {
     args[_key3] = arguments[_key3];
   }
 

packages/babel-plugin-transform-es2015-parameters/test/fixtures/parameters/rest-async-arrow-functions/expected.js

@@ -13,7 +13,7 @@ var x = function () {
   var _ref2 = babelHelpers.asyncToGenerator(function* () {
     if (noNeedToWork) return 0;
 
-    for (var _len = arguments.length, rest = Array(_len), _key = 0; _key < _len; _key++) {
+    for (var _len = arguments.length, rest = new Array(_len), _key = 0; _key < _len; _key++) {
       rest[_key] = arguments[_key];
     }
 

packages/babel-plugin-transform-es2015-parameters/test/fixtures/parameters/rest-binding-deoptimisation/expected.js

@@ -1,5 +1,5 @@
 var deepAssign = function () {
-  for (var _len = arguments.length, args = Array(_len), _key = 0; _key < _len; _key++) {
+  for (var _len = arguments.length, args = new Array(_len), _key = 0; _key < _len; _key++) {
     args[_key] = arguments[_key];
   }
 

packages/babel-plugin-transform-es2015-parameters/test/fixtures/parameters/rest-deepest-common-ancestor-earliest-child/expected.js

@@ -2,7 +2,7 @@
 function r() {
   if (noNeedToWork) return 0;
 
-  for (var _len = arguments.length, rest = Array(_len), _key = 0; _key < _len; _key++) {
+  for (var _len = arguments.length, rest = new Array(_len), _key = 0; _key < _len; _key++) {
     rest[_key] = arguments[_key];
   }
 
@@ -13,7 +13,7 @@ function r() {
 function r() {
   if (noNeedToWork) return 0;
 
-  for (var _len2 = arguments.length, rest = Array(_len2), _key2 = 0; _key2 < _len2; _key2++) {
+  for (var _len2 = arguments.length, rest = new Array(_len2), _key2 = 0; _key2 < _len2; _key2++) {
     rest[_key2] = arguments[_key2];
   }
 
@@ -25,7 +25,7 @@ function r() {
 function r() {
   if (noNeedToWork) return 0;
 
-  for (var _len3 = arguments.length, rest = Array(_len3), _key3 = 0; _key3 < _len3; _key3++) {
+  for (var _len3 = arguments.length, rest = new Array(_len3), _key3 = 0; _key3 < _len3; _key3++) {
     rest[_key3] = arguments[_key3];
   }
 
@@ -39,7 +39,7 @@ function r() {
 
 function r() {
   if (true) {
-    for (var _len4 = arguments.length, rest = Array(_len4), _key4 = 0; _key4 < _len4; _key4++) {
+    for (var _len4 = arguments.length, rest = new Array(_len4), _key4 = 0; _key4 < _len4; _key4++) {
       rest[_key4] = arguments[_key4];
     }
 
@@ -55,7 +55,7 @@ function r() {
 function r() {
   if (noNeedToWork) return 0;
 
-  for (var _len5 = arguments.length, rest = Array(_len5), _key5 = 0; _key5 < _len5; _key5++) {
+  for (var _len5 = arguments.length, rest = new Array(_len5), _key5 = 0; _key5 < _len5; _key5++) {
     rest[_key5] = arguments[_key5];
   }
 
@@ -65,7 +65,7 @@ function r() {
 
 
 function a() {
-  for (var _len6 = arguments.length, args = Array(_len6), _key6 = 0; _key6 < _len6; _key6++) {
+  for (var _len6 = arguments.length, args = new Array(_len6), _key6 = 0; _key6 < _len6; _key6++) {
     args[_key6] = arguments[_key6];
   }
 
@@ -78,7 +78,7 @@ function a() {
 
 
 function runQueue(queue) {
-  for (var _len7 = arguments.length, args = Array(_len7 > 1 ? _len7 - 1 : 0), _key7 = 1; _key7 < _len7; _key7++) {
+  for (var _len7 = arguments.length, args = new Array(_len7 > 1 ? _len7 - 1 : 0), _key7 = 1; _key7 < _len7; _key7++) {
     args[_key7 - 1] = arguments[_key7];
   }
 
@@ -90,7 +90,7 @@ function runQueue(queue) {
 
 function runQueue(queue) {
   if (foo) {
-    for (var _len8 = arguments.length, args = Array(_len8 > 1 ? _len8 - 1 : 0), _key8 = 1; _key8 < _len8; _key8++) {
+    for (var _len8 = arguments.length, args = new Array(_len8 > 1 ? _len8 - 1 : 0), _key8 = 1; _key8 < _len8; _key8++) {
       args[_key8 - 1] = arguments[_key8];
     }
 
@@ -103,7 +103,7 @@ function runQueue(queue) {
 function r() {
   if (noNeedToWork) return 0;
 
-  for (var _len9 = arguments.length, rest = Array(_len9), _key9 = 0; _key9 < _len9; _key9++) {
+  for (var _len9 = arguments.length, rest = new Array(_len9), _key9 = 0; _key9 < _len9; _key9++) {
     rest[_key9] = arguments[_key9];
   }
 

packages/babel-plugin-transform-es2015-parameters/test/fixtures/parameters/rest-length/expected.js

@@ -6,7 +6,7 @@ var t = function (f) {
 };
 
 function t(f) {
-  for (var _len = arguments.length, items = Array(_len > 1 ? _len - 1 : 0), _key = 1; _key < _len; _key++) {
+  for (var _len = arguments.length, items = new Array(_len > 1 ? _len - 1 : 0), _key = 1; _key < _len; _key++) {
     items[_key - 1] = arguments[_key];
   }
 

packages/babel-plugin-transform-es2015-parameters/test/fixtures/parameters/rest-member-expression-deoptimisation/expected.js

@@ -1,5 +1,5 @@
 var x = function (foo) {
-  for (var _len = arguments.length, bar = Array(_len > 1 ? _len - 1 : 0), _key = 1; _key < _len; _key++) {
+  for (var _len = arguments.length, bar = new Array(_len > 1 ? _len - 1 : 0), _key = 1; _key < _len; _key++) {
     bar[_key - 1] = arguments[_key];
   }
 
@@ -13,7 +13,7 @@ var y = function (foo) {
 };
 
 var b = function (x, y) {
-  for (var _len2 = arguments.length, args = Array(_len2 > 2 ? _len2 - 2 : 0), _key2 = 2; _key2 < _len2; _key2++) {
+  for (var _len2 = arguments.length, args = new Array(_len2 > 2 ? _len2 - 2 : 0), _key2 = 2; _key2 < _len2; _key2++) {
     args[_key2 - 2] = arguments[_key2];
   }
 
@@ -23,7 +23,7 @@ var b = function (x, y) {
 };
 
 var z = function (foo) {
-  for (var _len3 = arguments.length, bar = Array(_len3 > 1 ? _len3 - 1 : 0), _key3 = 1; _key3 < _len3; _key3++) {
+  for (var _len3 = arguments.length, bar = new Array(_len3 > 1 ? _len3 - 1 : 0), _key3 = 1; _key3 < _len3; _key3++) {
     bar[_key3 - 1] = arguments[_key3];
   }
 
@@ -33,7 +33,7 @@ var z = function (foo) {
 };
 
 var a = function (foo) {
-  for (var _len4 = arguments.length, bar = Array(_len4 > 1 ? _len4 - 1 : 0), _key4 = 1; _key4 < _len4; _key4++) {
+  for (var _len4 = arguments.length, bar = new Array(_len4 > 1 ? _len4 - 1 : 0), _key4 = 1; _key4 < _len4; _key4++) {
     bar[_key4 - 1] = arguments[_key4];
   }
 
@@ -43,7 +43,7 @@ var a = function (foo) {
 var b = function (foo) {
   var join = "join";
 
-  for (var _len5 = arguments.length, bar = Array(_len5 > 1 ? _len5 - 1 : 0), _key5 = 1; _key5 < _len5; _key5++) {
+  for (var _len5 = arguments.length, bar = new Array(_len5 > 1 ? _len5 - 1 : 0), _key5 = 1; _key5 < _len5; _key5++) {
     bar[_key5 - 1] = arguments[_key5];
   }
 
@@ -51,7 +51,7 @@ var b = function (foo) {
 };
 
 var b = function () {
-  for (var _len6 = arguments.length, bar = Array(_len6), _key6 = 0; _key6 < _len6; _key6++) {
+  for (var _len6 = arguments.length, bar = new Array(_len6), _key6 = 0; _key6 < _len6; _key6++) {
     bar[_key6] = arguments[_key6];
   }
 
@@ -67,7 +67,7 @@ var b = function (foo, baz) {
 };
 
 function x() {
-  for (var _len7 = arguments.length, rest = Array(_len7), _key7 = 0; _key7 < _len7; _key7++) {
+  for (var _len7 = arguments.length, rest = new Array(_len7), _key7 = 0; _key7 < _len7; _key7++) {
     rest[_key7] = arguments[_key7];
   }
 
@@ -75,7 +75,7 @@ function x() {
 }
 
 function swap() {
-  for (var _len8 = arguments.length, rest = Array(_len8), _key8 = 0; _key8 < _len8; _key8++) {
+  for (var _len8 = arguments.length, rest = new Array(_len8), _key8 = 0; _key8 < _len8; _key8++) {
     rest[_key8] = arguments[_key8];
   }
 
@@ -85,7 +85,7 @@ function swap() {
 }
 
 function forIn() {
-  for (var _len9 = arguments.length, rest = Array(_len9), _key9 = 0; _key9 < _len9; _key9++) {
+  for (var _len9 = arguments.length, rest = new Array(_len9), _key9 = 0; _key9 < _len9; _key9++) {
     rest[_key9] = arguments[_key9];
   }
 
@@ -95,7 +95,7 @@ function forIn() {
 }
 
 function inc() {
-  for (var _len10 = arguments.length, rest = Array(_len10), _key10 = 0; _key10 < _len10; _key10++) {
+  for (var _len10 = arguments.length, rest = new Array(_len10), _key10 = 0; _key10 < _len10; _key10++) {
     rest[_key10] = arguments[_key10];
   }
 
@@ -103,7 +103,7 @@ function inc() {
 }
 
 function dec() {
-  for (var _len11 = arguments.length, rest = Array(_len11), _key11 = 0; _key11 < _len11; _key11++) {
+  for (var _len11 = arguments.length, rest = new Array(_len11), _key11 = 0; _key11 < _len11; _key11++) {
     rest[_key11] = arguments[_key11];
   }
 
@@ -111,7 +111,7 @@ function dec() {
 }
 
 function del() {
-  for (var _len12 = arguments.length, rest = Array(_len12), _key12 = 0; _key12 < _len12; _key12++) {
+  for (var _len12 = arguments.length, rest = new Array(_len12), _key12 = 0; _key12 < _len12; _key12++) {
     rest[_key12] = arguments[_key12];
   }
 
@@ -119,7 +119,7 @@ function del() {
 }
 
 function method() {
-  for (var _len13 = arguments.length, rest = Array(_len13), _key13 = 0; _key13 < _len13; _key13++) {
+  for (var _len13 = arguments.length, rest = new Array(_len13), _key13 = 0; _key13 < _len13; _key13++) {
     rest[_key13] = arguments[_key13];
   }
 
@@ -127,7 +127,7 @@ function method() {
 }
 
 function newExp() {
-  for (var _len14 = arguments.length, rest = Array(_len14), _key14 = 0; _key14 < _len14; _key14++) {
+  for (var _len14 = arguments.length, rest = new Array(_len14), _key14 = 0; _key14 < _len14; _key14++) {
     rest[_key14] = arguments[_key14];
   }
 
@@ -137,7 +137,7 @@ function newExp() {
 
 
 function arrayDestructure() {
-  for (var _len15 = arguments.length, rest = Array(_len15), _key15 = 0; _key15 < _len15; _key15++) {
+  for (var _len15 = arguments.length, rest = new Array(_len15), _key15 = 0; _key15 < _len15; _key15++) {
     rest[_key15] = arguments[_key15];
   }
 
@@ -149,7 +149,7 @@ function arrayDestructure() {
 }
 
 function forOf() {
-  for (var _len16 = arguments.length, rest = Array(_len16), _key16 = 0; _key16 < _len16; _key16++) {
+  for (var _len16 = arguments.length, rest = new Array(_len16), _key16 = 0; _key16 < _len16; _key16++) {
     rest[_key16] = arguments[_key16];
   }
 
@@ -178,7 +178,7 @@ function forOf() {
 }
 
 function postfixIncrement() {
-  for (var _len17 = arguments.length, rest = Array(_len17), _key17 = 0; _key17 < _len17; _key17++) {
+  for (var _len17 = arguments.length, rest = new Array(_len17), _key17 = 0; _key17 < _len17; _key17++) {
     rest[_key17] = arguments[_key17];
   }
 
@@ -186,7 +186,7 @@ function postfixIncrement() {
 }
 
 function postfixDecrement() {
-  for (var _len18 = arguments.length, rest = Array(_len18), _key18 = 0; _key18 < _len18; _key18++) {
+  for (var _len18 = arguments.length, rest = new Array(_len18), _key18 = 0; _key18 < _len18; _key18++) {
     rest[_key18] = arguments[_key18];
   }
 

packages/babel-plugin-transform-es2015-parameters/test/fixtures/parameters/rest-nested-iife/expected.js

@@ -13,7 +13,7 @@ function broken(x) {
       return Foo;
     }(Bar);
 
-    for (var _len = arguments.length, foo = Array(_len > 1 ? _len - 1 : 0), _key = 1; _key < _len; _key++) {
+    for (var _len = arguments.length, foo = new Array(_len > 1 ? _len - 1 : 0), _key = 1; _key < _len; _key++) {
       foo[_key - 1] = arguments[_key];
     }
 

packages/babel-plugin-transform-es2015-parameters/test/fixtures/parameters/rest-spread-optimisation/expected.js

@@ -5,7 +5,7 @@ function foo() {
 
 
 function foo(a) {
-  for (var _len = arguments.length, b = Array(_len > 1 ? _len - 1 : 0), _key = 1; _key < _len; _key++) {
+  for (var _len = arguments.length, b = new Array(_len > 1 ? _len - 1 : 0), _key = 1; _key < _len; _key++) {
     b[_key - 1] = arguments[_key];
   }
 
@@ -13,7 +13,7 @@ function foo(a) {
 }
 
 function foo() {
-  for (var _len2 = arguments.length, b = Array(_len2), _key2 = 0; _key2 < _len2; _key2++) {
+  for (var _len2 = arguments.length, b = new Array(_len2), _key2 = 0; _key2 < _len2; _key2++) {
     b[_key2] = arguments[_key2];
   }
 
@@ -21,7 +21,7 @@ function foo() {
 }
 
 function foo() {
-  for (var _len3 = arguments.length, args = Array(_len3), _key3 = 0; _key3 < _len3; _key3++) {
+  for (var _len3 = arguments.length, args = new Array(_len3), _key3 = 0; _key3 < _len3; _key3++) {
     args[_key3] = arguments[_key3];
   }
 

packages/babel-plugin-transform-es2015-parameters/test/fixtures/regression/6057-expanded/expected.js

@@ -35,7 +35,7 @@ function (_Component) {
 
     _classCallCheck(this, App);
 
-    for (var _len = arguments.length, args = Array(_len), _key = 0; _key < _len; _key++) {
+    for (var _len = arguments.length, args = new Array(_len), _key = 0; _key < _len; _key++) {
       args[_key] = arguments[_key];
     }
 

packages/babel-plugin-transform-es2015-parameters/test/fixtures/regression/6057-simple/expected.js

@@ -1,7 +1,7 @@
 const a = 'bar';
 
 function foo() {
-  for (var _len = arguments.length, a = Array(_len), _key = 0; _key < _len; _key++) {
+  for (var _len = arguments.length, a = new Array(_len), _key = 0; _key < _len; _key++) {
     a[_key] = arguments[_key];
   }
 

packages/babel-plugin-transform-es2015-spread/test/fixtures/spread/known-rest/expected.js

@@ -1,5 +1,5 @@
 function foo() {
-  for (var _len = arguments.length, bar = Array(_len), _key = 0; _key < _len; _key++) {
+  for (var _len = arguments.length, bar = new Array(_len), _key = 0; _key < _len; _key++) {
     bar[_key] = arguments[_key];
   }
 

packages/babel-plugin-transform-react-constant-elements/test/fixtures/constant-elements/inline-elements/expected.js

@@ -1,6 +1,6 @@
 var REACT_ELEMENT_TYPE;
 
-function _jsx(type, props, key, children) { if (!REACT_ELEMENT_TYPE) { REACT_ELEMENT_TYPE = typeof Symbol === "function" && Symbol.for && Symbol.for("react.element") || 0xeac7; } var defaultProps = type && type.defaultProps; var childrenLength = arguments.length - 3; if (!props && childrenLength !== 0) { props = {}; } if (props && defaultProps) { for (var propName in defaultProps) { if (props[propName] === void 0) { props[propName] = defaultProps[propName]; } } } else if (!props) { props = defaultProps || {}; } if (childrenLength === 1) { props.children = children; } else if (childrenLength > 1) { var childArray = Array(childrenLength); for (var i = 0; i < childrenLength; i++) { childArray[i] = arguments[i + 3]; } props.children = childArray; } return { $$typeof: REACT_ELEMENT_TYPE, type: type, key: key === undefined ? null : '' + key, ref: null, props: props, _owner: null }; }
+function _jsx(type, props, key, children) { if (!REACT_ELEMENT_TYPE) { REACT_ELEMENT_TYPE = typeof Symbol === "function" && Symbol.for && Symbol.for("react.element") || 0xeac7; } var defaultProps = type && type.defaultProps; var childrenLength = arguments.length - 3; if (!props && childrenLength !== 0) { props = {}; } if (props && defaultProps) { for (var propName in defaultProps) { if (props[propName] === void 0) { props[propName] = defaultProps[propName]; } } } else if (!props) { props = defaultProps || {}; } if (childrenLength === 1) { props.children = children; } else if (childrenLength > 1) { var childArray = new Array(childrenLength); for (var i = 0; i < childrenLength; i++) { childArray[i] = arguments[i + 3]; } props.children = childArray; } return { $$typeof: REACT_ELEMENT_TYPE, type: type, key: key === undefined ? null : '' + key, ref: null, props: props, _owner: null }; }
 
 var _ref = _jsx("foo", {});