cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

perf: Use for loops while cloning classes

Browse Source
This commit is contained in:
Daniel Tschinder 2019-01-16 19:35:07 -08:00
parent f216975378
commit f12905b531
2 changed files with 12 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
packages/babel-parser/src/parser/node.js
View File

@ -29,8 +29,10 @@ class Node implements NodeBase {
__clone(): this {
// $FlowIgnore
const node2: any = new Node();
Object.keys(this).forEach(key => {
const newNode: any = new Node();
const keys = Object.keys(this);
for (let i = 0, length = keys.length; i < length; i++) {
const key = keys[i];
// Do not clone comments that are already attached to the node
if (
key !== "leadingComments" &&
@ -38,11 +40,11 @@ class Node implements NodeBase {
key !== "innerComments"
) {
// $FlowIgnore
node2[key] = this[key];
newNode[key] = this[key];
}
}
});
return node2;
return newNode;
}
}

7
packages/babel-parser/src/tokenizer/state.js
View File

@ -178,7 +178,9 @@ export default class State {
clone(skipArrays?: boolean): State {
const state = new State();
Object.keys(this).forEach(key => {
const keys = Object.keys(this);
for (let i = 0, length = keys.length; i < length; i++) {
const key = keys[i];
// $FlowIgnore
let val = this[key];
@ -188,7 +190,8 @@ export default class State {
// $FlowIgnore
state[key] = val;
});
}
return state;
}
}