add commonStandard module formatter - fixes #675

will be merged into strict formatters in next major
TODO: rewrite all module formatters as they've gotten out of han

lib/6to5/transformation/modules/_default.js

@@ -27,7 +27,7 @@ function DefaultFormatter(file) {
 }
 
 DefaultFormatter.prototype.doDefaultExportInterop = function (node) {
-  return node.default && !this.noInteropRequire && !this.hasNonDefaultExports;
+  return node.default && !this.noInteropRequireExport && !this.hasNonDefaultExports;
 };
 
 DefaultFormatter.prototype.bumpImportOccurences = function (node) {
@@ -228,7 +228,7 @@ DefaultFormatter.prototype.exportSpecifier = function (specifier, node, nodes) {
       // export * from "foo";
       nodes.push(this.buildExportsWildcard(ref, node));
     } else {
-      if (t.isSpecifierDefault(specifier) && !this.noInteropRequire) {
+      if (t.isSpecifierDefault(specifier) && !this.noInteropRequireExport) {
         // importing a default so we need to normalize it
         ref = t.callExpression(this.file.addHelper("interop-require"), [ref]);
       } else {

lib/6to5/transformation/modules/amd.js

@@ -86,7 +86,7 @@ AMDFormatter.prototype.importSpecifier = function (specifier, node, nodes) {
     this.ids[node.source.value] = ref;
   } else if (t.isImportBatchSpecifier(specifier)) {
     // import * as bar from "foo";
-  } else if (t.isSpecifierDefault(specifier) && !this.noInteropRequire) {
+  } else if (t.isSpecifierDefault(specifier) && !this.noInteropRequireImport) {
     // import foo from "foo";
     ref = t.callExpression(this.file.addHelper("interop-require"), [ref]);
   } else {

lib/6to5/transformation/modules/common-standard.js

@@ -0,0 +1,13 @@
+"use strict";
+
+module.exports = CommonStandardFormatter;
+
+var CommonStrictFormatter = require("./common-strict");
+var util = require("../../util");
+
+function CommonStandardFormatter() {
+  this.noInteropRequireImport = true;
+  CommonStrictFormatter.apply(this, arguments);
+}
+
+util.inherits(CommonStandardFormatter, CommonStrictFormatter);

lib/6to5/transformation/modules/common.js

@@ -14,7 +14,7 @@ function CommonJSFormatter() {
 util.inherits(CommonJSFormatter, DefaultFormatter);
 
 CommonJSFormatter.prototype.init = function () {
-  if (this.hasNonDefaultExports) {
+  if (!this.noInteropRequireImport && this.hasNonDefaultExports) {
     this.file.ast.program.body.push(util.template("exports-module-declaration", true));
   }
 };
@@ -27,19 +27,23 @@ CommonJSFormatter.prototype.importSpecifier = function (specifier, node, nodes)
   // import foo from "foo";
   if (t.isSpecifierDefault(specifier)) {
     if (!contains(this.file.dynamicImported, node)) {
-      ref = t.callExpression(this.file.addHelper("interop-require"), [ref]);
+      if (this.noInteropRequireImport) {
+        ref = t.memberExpression(ref, t.identifier("default"));
+      } else {
+        ref = t.callExpression(this.file.addHelper("interop-require"), [ref]);
+      }
     }
     nodes.push(t.variableDeclaration("var", [t.variableDeclarator(variableName, ref)]));
   } else {
     if (specifier.type === "ImportBatchSpecifier") {
+
+      if (!this.noInteropRequireImport) {
+          ref = t.callExpression(this.file.addHelper("interop-require-wildcard"), [ref]);
+      }
+
       // import * as bar from "foo";
       nodes.push(t.variableDeclaration("var", [
-        t.variableDeclarator(
-          variableName,
-          t.callExpression(this.file.addHelper("interop-require-wildcard"), [
-            ref
-          ])
-        )
+        t.variableDeclarator(variableName, ref)
       ]));
     } else {
       // import { foo } from "foo";

lib/6to5/transformation/modules/index.js

@@ -1,10 +1,11 @@
 module.exports = {
-  commonStrict: require("./common-strict"),
-  amdStrict:    require("./amd-strict"),
-  umdStrict:    require("./umd-strict"),
-  common:       require("./common"),
-  system:       require("./system"),
-  ignore:       require("./ignore"),
-  amd:          require("./amd"),
-  umd:          require("./umd")
+  commonStandard: require("./common-standard"),
+  commonStrict:   require("./common-strict"),
+  amdStrict:      require("./amd-strict"),
+  umdStrict:      require("./umd-strict"),
+  common:         require("./common"),
+  system:         require("./system"),
+  ignore:         require("./ignore"),
+  amd:            require("./amd"),
+  umd:            require("./umd")
 };

lib/6to5/transformation/modules/system.js

@@ -13,7 +13,8 @@ var map              = require("lodash/collection/map");
 
 function SystemFormatter(file) {
   this.exportIdentifier = file.generateUidIdentifier("export");
-  this.noInteropRequire = true;
+  this.noInteropRequireExport = true;
+  this.noInteropRequireImport = true;
 
   DefaultFormatter.apply(this, arguments);
 }