cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Support private properties in no-invalid-this (babel/eslint-plugin-babel#183)

Browse Source 
* add failing test

* support ClassPrivateProperty
This commit is contained in:
fergald 2019-08-24 17:12:15 +09:00
parent 693fa1aa0d
commit f3e2752df3
2 changed files with 19 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
eslint/babel-eslint-plugin/rules/no-invalid-this.js
View File

@ -5,17 +5,18 @@ const eslint = require('eslint');
const noInvalidThisRule = new eslint.Linter().getRules().get('no-invalid-this'); const noInvalidThisRule = new eslint.Linter().getRules().get('no-invalid-this');
module.exports = ruleComposer.filterReports( module.exports = ruleComposer.filterReports(
noInvalidThisRule, noInvalidThisRule,
(problem, metadata) => { (problem, metadata) => {
let inClassProperty = false; let inClassProperty = false;
let node = problem.node; let node = problem.node;
while (node) { while (node) {
if (node.type === "ClassProperty") { if (node.type === "ClassProperty" ||
node.type === "ClassPrivateProperty") {
inClassProperty = true; inClassProperty = true;
return; return;
} }
node = node.parent; node = node.parent;
} }

15
eslint/babel-eslint-plugin/tests/rules/no-invalid-this.js
View File

@ -602,6 +602,21 @@ const patterns = [
valid: [NORMAL, USE_STRICT, IMPLIED_STRICT, MODULES], valid: [NORMAL, USE_STRICT, IMPLIED_STRICT, MODULES],
invalid: [] invalid: []
}, },
// Class Private Instance Properties.
{
code: "class A {#a = this.b;};",
parserOptions: { ecmaVersion: 6 },
valid: [NORMAL, USE_STRICT, IMPLIED_STRICT, MODULES],
invalid: []
},
{
code: "class A {#a = () => {return this.b;};};",
parserOptions: { ecmaVersion: 6 },
valid: [NORMAL, USE_STRICT, IMPLIED_STRICT, MODULES],
invalid: []
},
]; ];
const ruleTester = new RuleTester(); const ruleTester = new RuleTester();