From f657598c72f5296895d2282b6bb4bd36713a7d42 Mon Sep 17 00:00:00 2001 From: Sebastian McKenzie Date: Sat, 9 May 2015 16:52:57 +0100 Subject: [PATCH] remove noop traversal visitors methods --- src/babel/traversal/path/index.js | 9 ++++----- src/babel/traversal/visitors.js | 4 ---- 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/src/babel/traversal/path/index.js b/src/babel/traversal/path/index.js index a70575bee4..8ddff8c401 100644 --- a/src/babel/traversal/path/index.js +++ b/src/babel/traversal/path/index.js @@ -745,11 +745,10 @@ export default class TraversalPath { if (!node) return; var opts = this.opts; - var fns = [].concat(opts[key]); + if (!opts[key] && !opts[node.type]) return; - if (opts[node.type]) { - fns = fns.concat(opts[node.type][key]); - } + var fns = [].concat(opts[key]); + if (opts[node.type]) fns = fns.concat(opts[node.type][key]); for (var fn of (fns: Array)) { if (!fn) continue; @@ -789,7 +788,7 @@ export default class TraversalPath { visit(): boolean { if (this.isBlacklisted()) return false; - if (this.opts.shouldSkip(this)) return false; + if (this.opts.shouldSkip && this.opts.shouldSkip(this)) return false; this.call("enter"); diff --git a/src/babel/traversal/visitors.js b/src/babel/traversal/visitors.js index 3d99110546..55bd53d5d2 100644 --- a/src/babel/traversal/visitors.js +++ b/src/babel/traversal/visitors.js @@ -82,10 +82,6 @@ export function verify(visitor) { throw new Error(messages.get("traverseVerifyRootFunction")); } - if (!visitor.enter) visitor.enter = function () { }; - if (!visitor.exit) visitor.exit = function () { }; - if (!visitor.shouldSkip) visitor.shouldSkip = function () { return false; }; - for (var nodeType in visitor) { if (shouldIgnoreKey(nodeType)) continue;