From dd985c3be3186049ffaf205ef2227108f2e5fb65 Mon Sep 17 00:00:00 2001 From: Logan Smyth Date: Mon, 3 Sep 2018 12:21:54 -0700 Subject: [PATCH 1/2] Verify 'sourceMap' with hasOwnProperty since it can be falsy. --- packages/babel-core/src/config/config-chain.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/babel-core/src/config/config-chain.js b/packages/babel-core/src/config/config-chain.js index f46d0ee2ac..b9e13a1307 100644 --- a/packages/babel-core/src/config/config-chain.js +++ b/packages/babel-core/src/config/config-chain.js @@ -542,7 +542,7 @@ function normalizeOptions(opts: ValidatedOptions): ValidatedOptions { // "sourceMap" is just aliased to sourceMap, so copy it over as // we merge the options together. - if (options.sourceMap) { + if (options.hasOwnProperty("sourceMap")) { options.sourceMaps = options.sourceMap; delete options.sourceMap; } From 9232e8b4058e2cd6235bfd230cb7b1ca684af1d7 Mon Sep 17 00:00:00 2001 From: Logan Smyth Date: Mon, 3 Sep 2018 18:44:10 -0700 Subject: [PATCH 2/2] Validate the type of the 'version' option for transform-runtime. --- packages/babel-plugin-transform-runtime/src/index.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/packages/babel-plugin-transform-runtime/src/index.js b/packages/babel-plugin-transform-runtime/src/index.js index 88fe373cc0..7fb69f49d5 100644 --- a/packages/babel-plugin-transform-runtime/src/index.js +++ b/packages/babel-plugin-transform-runtime/src/index.js @@ -72,6 +72,9 @@ export default declare((api, options, dirname) => { `but got ${JSON.stringify(corejsVersion)}.`, ); } + if (typeof runtimeVersion !== "string") { + throw new Error(`The 'version' option must be a version string.`); + } function has(obj, key) { return Object.prototype.hasOwnProperty.call(obj, key);