cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Remove option-filtering options from the final options results. (#8315)

Browse Source 
| Q                        | A <!--(Can use an emoji 👍) -->
| ------------------------ | ---
| Fixed Issues?            | Fixes https://github.com/babel/babel-loader/issues/642
| Patch: Bug Fix?          | Y
| Major: Breaking Change?  | N
| Minor: New Feature?      |
| Tests Added + Pass?      | Yes
| Documentation PR Link    | <!-- If only readme change, add `[skip ci]` to your commits -->
| Any Dependency Changes?  |
| License                  | MIT

Since these were getting left in, things that loaded the config, and then passed in back to Babel would get `test` and such _twice_, which could lead to either bad configuration merging, or no configuration at all if the patterns were relative to different directories, as was the case in https://github.com/babel/babel-loader/issues/642.
This commit is contained in:
Logan Smyth 2018-07-13 07:01:11 -07:00 committed by GitHub
parent dca6125128
commit fd9ebf9e1d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/babel-core/src/config/config-chain.js
View File

@ -500,11 +500,15 @@ function normalizeOptions(opts: ValidatedOptions): ValidatedOptions {
}; };
delete options.extends; delete options.extends;
delete options.env; delete options.env;
delete options.overrides;
delete options.plugins; delete options.plugins;
delete options.presets; delete options.presets;
delete options.passPerPreset; delete options.passPerPreset;
delete options.ignore; delete options.ignore;
delete options.only; delete options.only;
delete options.test;
delete options.include;
delete options.exclude;
// "sourceMap" is just aliased to sourceMap, so copy it over as // "sourceMap" is just aliased to sourceMap, so copy it over as
// we merge the options together. // we merge the options together.

17
packages/babel-core/test/config-chain.js
View File

@ -899,6 +899,23 @@ describe("buildConfigChain", function() {
expect(opts.comments).toBe(true); expect(opts.comments).toBe(true);
}); });
it("should remove the overrides and filtering fields from the options", () => {
const opts = loadOptions({
cwd: fixture("nonexistant-fake"),
filename: fixture("nonexistant-fake", "src.js"),
babelrc: false,
overrides: [],
test: /^/,
include: /^/,
exclude: [],
});
expect(opts.overrides).toBeUndefined();
expect(opts.test).toBeUndefined();
expect(opts.include).toBeUndefined();
expect(opts.exclude).toBeUndefined();
});
}); });
describe("config files", () => { describe("config files", () => {