cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Use more ideal mocha hooks (#3446)

Browse Source 
* setup() instead of manual before().
* suiteTeardown() instead of afterEach().
This commit is contained in:
Jesse McCarthy 2016-05-19 08:26:59 -04:00
parent 7594204777
commit ff044bbb0f
1 changed files with 5 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
packages/babel-core/test/api.js
View File

@ -432,23 +432,19 @@ suite("api", function () {
var oldBabelEnv = process.env.BABEL_ENV; var oldBabelEnv = process.env.BABEL_ENV;
var oldNodeEnv = process.env.NODE_ENV; var oldNodeEnv = process.env.NODE_ENV;
setup(function () {
// This this a global side effect and we need to make sure it's localized // Tests need to run with the default and specific values for these. They
// to every test below. // need to be cleared for each test.
function before() {
delete process.env.BABEL_ENV; delete process.env.BABEL_ENV;
delete process.env.NODE_ENV; delete process.env.NODE_ENV;
} });
suiteTeardown(function () {
afterEach(function () {
process.env.BABEL_ENV = oldBabelEnv; process.env.BABEL_ENV = oldBabelEnv;
process.env.NODE_ENV = oldNodeEnv; process.env.NODE_ENV = oldNodeEnv;
}); });
test("default", function () { test("default", function () {
before();
var result = babel.transform("foo;", { var result = babel.transform("foo;", {
env: { env: {
development: { code: false } development: { code: false }
@ -459,8 +455,6 @@ suite("api", function () {
}); });
test("BABEL_ENV", function () { test("BABEL_ENV", function () {
before();
process.env.BABEL_ENV = "foo"; process.env.BABEL_ENV = "foo";
var result = babel.transform("foo;", { var result = babel.transform("foo;", {
env: { env: {
@ -471,8 +465,6 @@ suite("api", function () {
}); });
test("NODE_ENV", function () { test("NODE_ENV", function () {
before();
process.env.NODE_ENV = "foo"; process.env.NODE_ENV = "foo";
var result = babel.transform("foo;", { var result = babel.transform("foo;", {
env: { env: {