aea0fcd599
* Transform initializers with ids in rest elements
Fix issue 11281. Transform parameters with default initializers that
have ids that are also in a parameter with a rest element.
Before, these parameters were not transformed.
* Add plugin-transform-parameters as dependency
* Remove outdated comment
* Use set instead of array for paramsWithRestElement
* Skip when encounter "Scope"
Previously, f({...R}, f = R => R) would be incorrectly transformed.
* Pass in loose mode option instead of false
* Address review and re-organize tests
Checking the RHS of an assignment pattern/checking the parent of
an identifier node fails on cases like "({...R}, a = f(R))" or
"({...R}, {[R.key]: a = 42})".
Also refactor tests by removing unecessary tests and
separating "should transform" from "should not transform" tests.
36 lines
1.0 KiB
JavaScript
36 lines
1.0 KiB
JavaScript
import { declare } from "@babel/helper-plugin-utils";
|
|
import convertFunctionParams from "./params";
|
|
import convertFunctionRest from "./rest";
|
|
export { convertFunctionParams };
|
|
|
|
export default declare((api, options) => {
|
|
api.assertVersion(7);
|
|
|
|
const { loose } = options;
|
|
return {
|
|
name: "transform-parameters",
|
|
|
|
visitor: {
|
|
Function(path) {
|
|
if (
|
|
path.isArrowFunctionExpression() &&
|
|
path
|
|
.get("params")
|
|
.some(param => param.isRestElement() || param.isAssignmentPattern())
|
|
) {
|
|
// default/rest visitors require access to `arguments`, so it cannot be an arrow
|
|
path.arrowFunctionToExpression();
|
|
}
|
|
|
|
const convertedRest = convertFunctionRest(path);
|
|
const convertedParams = convertFunctionParams(path, loose);
|
|
|
|
if (convertedRest || convertedParams) {
|
|
// Manually reprocess this scope to ensure that the moved params are updated.
|
|
path.scope.crawl();
|
|
}
|
|
},
|
|
},
|
|
};
|
|
});
|