History

Benedikt Meurer 00342452e2 Fix OOB string character access in Printer#_maybeAddParen. (#6589 )

* Fix OOB string character access in Printer#_maybeAddParen.

The `_maybeAddParen` method of the `Printer` class does

```js
const chaPost = str[i + 1]
```

without checking that `i + 1` is still within the bounds of `str`. It
seems like this triggers fairly often that the `str[i + 1]` access is
out of bounds. The first out of bounds access will turn the KeyedLoadIC
(in case of V8) into *MEGAMORPHIC* state, which is significantly slower
for strings (there's a fix in flight for V8 to mitigate the cost a bit
in that case). Even worse than that, the out of bounds access also
pollutes the later comparisons, namely

```js
chaPost === "/"
```

and

```js
chaPost === "*"
```

which are now no longer monomorphic on strings, since `chaPost` was
sometimes `undefined`.

This is a non-breaking performance fix, which improves babel execution
on the [web-tooling-benchmark](github.com/v8/web-tooling-benchmark)
workload by around 6-9%.

* Restructure and optimize the code a bit.

2017-10-30 09:16:44 -04:00

src

Fix OOB string character access in Printer#_maybeAddParen. (#6589 )

2017-10-30 09:16:44 -04:00

test

Scoped: updated numerous docs with scoped packages change [skip ci]

2017-10-16 22:49:57 -04:00

.npmignore

Misc (#5545 )

2017-03-25 21:46:16 -04:00

package.json

Update to babylon v7 beta.30 (#6587 )

2017-10-28 20:01:52 -04:00

README.md

Scoped: update readme headers to @babel/ [skip ci]

2017-10-16 22:49:57 -04:00

README.md

@babel/generator

Turns an AST into code.

Install

npm install --save-dev @babel/generator

Usage

import {parse} from 'babylon';
import generate from '@babel/generator';

const code = 'class Example {}';
const ast = parse(code);

const output = generate(ast, { /* options */ }, code);

Options

Options for formatting output:

name	type	default	description
auxiliaryCommentBefore	string		Optional string to add as a block comment at the start of the output file
auxiliaryCommentAfter	string		Optional string to add as a block comment at the end of the output file
shouldPrintComment	function	`opts.comments`	Function that takes a comment (as a string) and returns `true` if the comment should be included in the output. By default, comments are included if `opts.comments` is `true` or if `opts.minifed` is `false` and the comment contains `@preserve` or `@license`
retainLines	boolean	`false`	Attempt to use the same line numbers in the output code as in the source code (helps preserve stack traces)
retainFunctionParens	boolean	`false`	Retain parens around function expressions (could be used to change engine parsing behavior)
comments	boolean	`true`	Should comments be included in output
compact	boolean or `'auto'`	`opts.minified`	Set to `true` to avoid adding whitespace for formatting
minified	boolean	`false`	Should the output be minified
concise	boolean	`false`	Set to `true` to reduce whitespace (but not as much as `opts.compact`)
filename	string		Used in warning messages
jsonCompatibleStrings	boolean	`false`	Set to true to run `jsesc` with "json": true to print "\u00A9" vs. "©";

Options for source maps:

name	type	default	description
sourceMaps	boolean	`false`	Enable generating source maps
sourceMapTarget	string		The filename of the generated code that the source map will be associated with
sourceRoot	string		A root for all relative URLs in the source map
sourceFileName	string		The filename for the source code (i.e. the code in the `code` argument). This will only be used if `code` is a string.

AST from Multiple Sources

In most cases, Babel does a 1:1 transformation of input-file to output-file. However, you may be dealing with AST constructed from multiple sources - JS files, templates, etc. If this is the case, and you want the sourcemaps to reflect the correct sources, you'll need to pass an object to generate as the code parameter. Keys should be the source filenames, and values should be the source content.

Here's an example of what that might look like:

import {parse} from 'babylon';
import generate from '@babel/generator';

const a = 'var a = 1;';
const b = 'var b = 2;';
const astA = parse(a, { sourceFilename: 'a.js' });
const astB = parse(b, { sourceFilename: 'b.js' });
const ast = {
  type: 'Program',
  body: [].concat(astA.program.body, astB.program.body)
};

const { code, map } = generate(ast, { sourceMaps: true }, {
  'a.js': a,
  'b.js': b
});

// Sourcemap will point to both a.js and b.js where appropriate.