From 51f894c6167b2558723f3af8a669d0ce19eedf5a Mon Sep 17 00:00:00 2001 From: Miel Truyen Date: Fri, 8 Nov 2019 20:04:23 +0100 Subject: [PATCH] Removed some Todo's that were no longer a TODO --- packages/csx-custom-elements/src/vdom/render.js | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/packages/csx-custom-elements/src/vdom/render.js b/packages/csx-custom-elements/src/vdom/render.js index 20d6a55..90ae977 100644 --- a/packages/csx-custom-elements/src/vdom/render.js +++ b/packages/csx-custom-elements/src/vdom/render.js @@ -6,8 +6,6 @@ import { NodeTreeRenderer } from "./renderers"; -// TODO consider using existence of renderer.remove to identify whether a VNode is ChildNode or not -// TODO Rework all below so we can determine per type how to handle it (not all represent a childNode of the host etc...) // TODO Element renderer (for things that are already DOM-elements) export function getNodeMeta(vnode){ if(vnode===undefined||vnode===null) return undefined; // Indicate it shouldn't render @@ -49,7 +47,6 @@ export function getNodeMeta(vnode){ export function render(vnode, opts = {}) { // TODO innerHTML, innerText and other tags/props that are trickyer then just mapping value to attribute (see NodeTreeRenderer) // TODO ref-prop (should it only return once all child els are created and appended to the child?!) - // TODO Proper updating of a previous rendered vnode (we're working on it!) /** * @@ -182,7 +179,7 @@ export function render(vnode, opts = {}) { else item.host.removeChild(oldChild.element); } - queuedItems.push(child);// TODO where should the new child be inserted... + queuedItems.push(child); } previous = child.item; }