NOOP: Format all layer's SQL code (#917)

I would like to reformat all of our SQL to have a concise coding style.
This makes it far easier to understand the code for a casual contributor,
and lets us spot errors more easily.

Most importantly, it makes it much easier to grep (search) the code because it is more likely to be in the same syntax

Some key changes:
* SQL keywords are always UPPERCASE, e.g. `SELECT WHEN AS END ...`
* types, variables, aliases, and field names (identifiers) are always lower case
* `LANGUAGE 'plpgsql'` is now `LANGUAGE plpgsql` (no quotes)
* a few minor spacing/semicolon cleanups

P.S. Per @TomPohys request, `TABLE` is spelled using upper case despite being a type for consistency with PG Docs. Same for `LANGUAGE SQL` vs `LANGUAGE plpgsql`.

layers/water_name/update_water_lakeline.sql

@@ -3,76 +3,89 @@ DROP TRIGGER IF EXISTS trigger_update_line ON osm_water_polygon;
 DROP TRIGGER IF EXISTS trigger_insert_line ON osm_water_polygon;
 
 CREATE OR REPLACE VIEW osm_water_lakeline_view AS
-	SELECT wp.osm_id,
-		ll.wkb_geometry AS geometry,
-		name, name_en, name_de,
-		update_tags(tags, ll.wkb_geometry) AS tags,
-		ST_Area(wp.geometry) AS area,
-		is_intermittent
-    FROM osm_water_polygon AS wp
-    INNER JOIN lake_centerline ll ON wp.osm_id = ll.osm_id
-    WHERE wp.name <> '' AND ST_IsValid(wp.geometry)
-;
+SELECT wp.osm_id,
+       ll.wkb_geometry                    AS geometry,
+       name,
+       name_en,
+       name_de,
+       update_tags(tags, ll.wkb_geometry) AS tags,
+       ST_Area(wp.geometry)               AS area,
+       is_intermittent
+FROM osm_water_polygon AS wp
+         INNER JOIN lake_centerline ll ON wp.osm_id = ll.osm_id
+WHERE wp.name <> ''
+  AND ST_IsValid(wp.geometry);
 
 -- etldoc:  osm_water_polygon ->  osm_water_lakeline
 -- etldoc:  lake_centerline  ->  osm_water_lakeline
 CREATE TABLE IF NOT EXISTS osm_water_lakeline AS
-SELECT * FROM osm_water_lakeline_view;
-DO $$
+SELECT *
+FROM osm_water_lakeline_view;
+DO
+$$
     BEGIN
-        ALTER TABLE osm_water_lakeline ADD CONSTRAINT osm_water_lakeline_pk PRIMARY KEY (osm_id);
-    EXCEPTION WHEN others then
-        RAISE NOTICE 'primary key osm_water_lakeline_pk already exists in osm_water_lakeline.';
+        ALTER TABLE osm_water_lakeline
+            ADD CONSTRAINT osm_water_lakeline_pk PRIMARY KEY (osm_id);
+    EXCEPTION
+        WHEN OTHERS THEN
+            RAISE NOTICE 'primary key osm_water_lakeline_pk already exists in osm_water_lakeline.';
     END;
 $$;
-CREATE INDEX IF NOT EXISTS osm_water_lakeline_geometry_idx ON osm_water_lakeline USING gist(geometry);
+CREATE INDEX IF NOT EXISTS osm_water_lakeline_geometry_idx ON osm_water_lakeline USING gist (geometry);
 
 -- Handle updates
 
 CREATE SCHEMA IF NOT EXISTS water_lakeline;
 
-CREATE OR REPLACE FUNCTION water_lakeline.delete() RETURNS trigger AS $BODY$
+CREATE OR REPLACE FUNCTION water_lakeline.delete() RETURNS trigger AS
+$$
 BEGIN
-    DELETE FROM osm_water_lakeline
-    WHERE osm_water_lakeline.osm_id = OLD.osm_id ;
+    DELETE
+    FROM osm_water_lakeline
+    WHERE osm_water_lakeline.osm_id = OLD.osm_id;
 
-    RETURN null;
+    RETURN NULL;
 END;
-$BODY$ language plpgsql;
+$$ LANGUAGE plpgsql;
 
-CREATE OR REPLACE FUNCTION water_lakeline.update() RETURNS trigger AS $BODY$
+CREATE OR REPLACE FUNCTION water_lakeline.update() RETURNS trigger AS
+$$
 BEGIN
     UPDATE osm_water_lakeline
     SET (osm_id, geometry, name, name_en, name_de, tags, area, is_intermittent) =
-        (SELECT * FROM osm_water_lakeline_view WHERE osm_water_lakeline_view.osm_id = NEW.osm_id)
+            (SELECT * FROM osm_water_lakeline_view WHERE osm_water_lakeline_view.osm_id = NEW.osm_id)
     WHERE osm_water_lakeline.osm_id = NEW.osm_id;
 
-    RETURN null;
+    RETURN NULL;
 END;
-$BODY$ language plpgsql;
+$$ LANGUAGE plpgsql;
 
-CREATE OR REPLACE FUNCTION water_lakeline.insert() RETURNS trigger AS $BODY$
+CREATE OR REPLACE FUNCTION water_lakeline.insert() RETURNS trigger AS
+$$
 BEGIN
     INSERT INTO osm_water_lakeline
     SELECT *
     FROM osm_water_lakeline_view
     WHERE osm_water_lakeline_view.osm_id = NEW.osm_id;
 
-    RETURN null;
+    RETURN NULL;
 END;
-$BODY$ language plpgsql;
+$$ LANGUAGE plpgsql;
 
 CREATE TRIGGER trigger_delete_line
-    AFTER DELETE ON osm_water_polygon
+    AFTER DELETE
+    ON osm_water_polygon
     FOR EACH ROW
-    EXECUTE PROCEDURE water_lakeline.delete();
+EXECUTE PROCEDURE water_lakeline.delete();
 
 CREATE TRIGGER trigger_update_line
-    AFTER UPDATE ON osm_water_polygon
+    AFTER UPDATE
+    ON osm_water_polygon
     FOR EACH ROW
-    EXECUTE PROCEDURE water_lakeline.update();
+EXECUTE PROCEDURE water_lakeline.update();
 
 CREATE TRIGGER trigger_insert_line
-    AFTER INSERT ON osm_water_polygon
+    AFTER INSERT
+    ON osm_water_polygon
     FOR EACH ROW
-    EXECUTE PROCEDURE water_lakeline.insert();
+EXECUTE PROCEDURE water_lakeline.insert();