From df6906b7b53e49c0ee22d84de1d6a60cff793dc7 Mon Sep 17 00:00:00 2001 From: Brian Sperlongano Date: Mon, 25 Apr 2022 07:42:01 -0400 Subject: [PATCH] Remove unneeded waterway='' check (#1377) This PR removes an unnecessary check in water.yml. generated SQL before: ``` SELECT CASE WHEN waterway='riverbank' THEN 'river' WHEN "waterway" = 'dock' THEN 'dock' WHEN "water" = 'river' OR "waterway" = 'riverbank' THEN 'river' WHEN "waterway" = '' THEN 'lake' ELSE 'lake' END; ``` generated SQL after: ``` SELECT CASE WHEN waterway='riverbank' THEN 'river' WHEN "waterway" = 'dock' THEN 'dock' WHEN "water" = 'river' OR "waterway" = 'riverbank' THEN 'river' ELSE 'lake' END; ``` The `waterway=''` test is purely redundant because it returns the same value as the fall-through ELSE case: `lake`. --- layers/water/water.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/layers/water/water.yaml b/layers/water/water.yaml index e4c4344..a7d3dda 100644 --- a/layers/water/water.yaml +++ b/layers/water/water.yaml @@ -26,7 +26,6 @@ layer: water: 'river' waterway: 'riverbank' lake: - waterway: '' ocean: intermittent: description: |