e6a1000155
Some of the `update_osm_${LAYER}`-functions, which are executed by triggers on updates, execute an UPDATE statement on the same tables that have these triggers. This causes the trigger functions `flag` and `store` to run multiple times for one record.
For instance, if I add log in the trigger functions and run an INSERT on `osm_housenumber_point`, this output is generated:
```
NOTICE: Store
NOTICE: Flag
NOTICE: Refresh housenumber
NOTICE: Flag
NOTICE: Store
NOTICE: Flag
INSERT 0 1
```
If we limit the triggers from executing if they are called from another trigger using `pg_trigger_depth() < 1`, the triggers will only be triggered once per record:
```
NOTICE: Store
NOTICE: Flag
NOTICE: Refresh housenumber
INSERT 0 1
```
This will prevent redunant executions and might improve update performance.
Co-authored-by: Patrik Sylve <patrik.sylve@t-kartor.com>
105 lines
2.9 KiB
PL/PgSQL
105 lines
2.9 KiB
PL/PgSQL
DROP TRIGGER IF EXISTS trigger_flag ON osm_housenumber_point;
|
|
DROP TRIGGER IF EXISTS trigger_store ON osm_housenumber_point;
|
|
DROP TRIGGER IF EXISTS trigger_refresh ON housenumber.updates;
|
|
|
|
CREATE SCHEMA IF NOT EXISTS housenumber;
|
|
|
|
CREATE TABLE IF NOT EXISTS housenumber.osm_ids
|
|
(
|
|
osm_id bigint PRIMARY KEY
|
|
);
|
|
|
|
-- etldoc: osm_housenumber_point -> osm_housenumber_point
|
|
CREATE OR REPLACE FUNCTION convert_housenumber_point(full_update boolean) RETURNS void AS
|
|
$$
|
|
UPDATE osm_housenumber_point
|
|
SET geometry =
|
|
CASE
|
|
WHEN ST_NPoints(ST_ConvexHull(geometry)) = ST_NPoints(geometry)
|
|
THEN ST_Centroid(geometry)
|
|
ELSE ST_PointOnSurface(geometry)
|
|
END
|
|
WHERE (full_update OR osm_id IN (SELECT osm_id FROM housenumber.osm_ids))
|
|
AND ST_GeometryType(geometry) <> 'ST_Point'
|
|
AND ST_IsValid(geometry);
|
|
|
|
-- we don't need exact name just to know if it's present
|
|
UPDATE osm_housenumber_point
|
|
SET has_name =
|
|
CASE
|
|
WHEN has_name = '' THEN '0'
|
|
ELSE '1'
|
|
END
|
|
WHERE (full_update OR osm_id IN (SELECT osm_id FROM housenumber.osm_ids));
|
|
|
|
$$ LANGUAGE SQL;
|
|
|
|
SELECT convert_housenumber_point(true);
|
|
|
|
-- Handle updates
|
|
|
|
CREATE OR REPLACE FUNCTION housenumber.store() RETURNS trigger AS
|
|
$$
|
|
BEGIN
|
|
INSERT INTO housenumber.osm_ids VALUES (NEW.osm_id) ON CONFLICT (osm_id) DO NOTHING;
|
|
RETURN NULL;
|
|
END;
|
|
$$ LANGUAGE plpgsql;
|
|
|
|
CREATE TABLE IF NOT EXISTS housenumber.updates
|
|
(
|
|
id serial PRIMARY KEY,
|
|
t text,
|
|
UNIQUE (t)
|
|
);
|
|
CREATE OR REPLACE FUNCTION housenumber.flag() RETURNS trigger AS
|
|
$$
|
|
BEGIN
|
|
INSERT INTO housenumber.updates(t) VALUES ('y') ON CONFLICT(t) DO NOTHING;
|
|
RETURN NULL;
|
|
END;
|
|
$$ LANGUAGE plpgsql;
|
|
|
|
CREATE OR REPLACE FUNCTION housenumber.refresh() RETURNS trigger AS
|
|
$$
|
|
DECLARE
|
|
t TIMESTAMP WITH TIME ZONE := clock_timestamp();
|
|
BEGIN
|
|
RAISE LOG 'Refresh housenumber';
|
|
|
|
-- Analyze tracking and source tables before performing update
|
|
ANALYZE housenumber.osm_ids;
|
|
ANALYZE osm_housenumber_point;
|
|
|
|
PERFORM convert_housenumber_point(false);
|
|
-- noinspection SqlWithoutWhere
|
|
DELETE FROM housenumber.osm_ids;
|
|
-- noinspection SqlWithoutWhere
|
|
DELETE FROM housenumber.updates;
|
|
|
|
RAISE LOG 'Refresh housenumber done in %', age(clock_timestamp(), t);
|
|
RETURN NULL;
|
|
END;
|
|
$$ LANGUAGE plpgsql;
|
|
|
|
CREATE TRIGGER trigger_store
|
|
AFTER INSERT OR UPDATE
|
|
ON osm_housenumber_point
|
|
FOR EACH ROW
|
|
WHEN (pg_trigger_depth() < 1)
|
|
EXECUTE PROCEDURE housenumber.store();
|
|
|
|
CREATE TRIGGER trigger_flag
|
|
AFTER INSERT OR UPDATE
|
|
ON osm_housenumber_point
|
|
FOR EACH STATEMENT
|
|
WHEN (pg_trigger_depth() < 1)
|
|
EXECUTE PROCEDURE housenumber.flag();
|
|
|
|
CREATE CONSTRAINT TRIGGER trigger_refresh
|
|
AFTER INSERT
|
|
ON housenumber.updates
|
|
INITIALLY DEFERRED
|
|
FOR EACH ROW
|
|
EXECUTE PROCEDURE housenumber.refresh();
|