miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 4 Packages Projects Releases Wiki Activity

fix(react): Update error message for invalid remote name (#19744)

Browse Source
This commit is contained in:
Nicholas Cunningham 2023-10-23 09:09:22 -06:00 committed by GitHub
parent b8296859f2
commit 022f1ea355
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 21 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
packages/angular/src/utils/mf/utils.ts
View File

@ -48,7 +48,14 @@ export function getFunctionDeterminateRemoteUrl(isServer: boolean = false) {
const remoteEntry = isServer ? 'server/remoteEntry.js' : 'remoteEntry.mjs';
return function (remote: string) {
const remoteConfiguration = readCachedProjectConfiguration(remote);
let remoteConfiguration = null;
try {
remoteConfiguration = readCachedProjectConfiguration(remote);
} catch (e) {
throw new Error(
`Cannot find remote "${remote}". Check that the remote name is correct in your module federation config file.\n`
);
}
const serveTarget = remoteConfiguration?.targets?.[target];
if (!serveTarget) {

6
packages/nx/src/project-graph/project-graph.ts
View File

@ -50,7 +50,11 @@ export function readCachedProjectConfiguration(
): ProjectConfiguration {
const graph = readCachedProjectGraph();
const node = graph.nodes[projectName];
return node.data;
try {
return node.data;
} catch (e) {
throw new Error(`Cannot find project: '${projectName}' in your workspace.`);
}
}
/**

9
packages/react/src/module-federation/utils.ts
View File

@ -21,7 +21,14 @@ export function getFunctionDeterminateRemoteUrl(isServer: boolean = false) {
const remoteEntry = isServer ? 'server/remoteEntry.js' : 'remoteEntry.js';
return function (remote: string) {
const remoteConfiguration = readCachedProjectConfiguration(remote);
let remoteConfiguration = null;
try {
remoteConfiguration = readCachedProjectConfiguration(remote);
} catch (e) {
throw new Error(
`Cannot find remote: "${remote}". Check that the remote name is correct in your module federation config file.\n`
);
}
const serveTarget = remoteConfiguration?.targets?.[target];
if (!serveTarget) {